Skip to content

feat: preferences settings revamp#1483

Merged
rohanchkrabrty merged 5 commits intomainfrom
feat-profilw-revamp
Apr 6, 2026
Merged

feat: preferences settings revamp#1483
rohanchkrabrty merged 5 commits intomainfrom
feat-profilw-revamp

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Added GeneralView and PreferencesView components to the SDK with full profile settings UI
  • Introduced reusable SDK primitives: ViewContainer, ViewHeader, ImageUpload, and DeleteOrganizationDialog
  • Upgraded SDK to use Apsara v1 and updated client-demo app to showcase the new settings pages

@rohanchkrabrty rohanchkrabrty self-assigned this Mar 27, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Apr 6, 2026 4:42am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 27, 2026

Warning

Rate limit exceeded

@rohanchkrabrty has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 26 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 6 minutes and 26 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: be018736-46eb-45fc-b779-ea6630c55ae1

📥 Commits

Reviewing files that changed from the base of the PR and between 1b73eaf and 93f25a1.

📒 Files selected for processing (11)
  • web/apps/client-demo/src/Router.tsx
  • web/apps/client-demo/src/pages/Settings.tsx
  • web/apps/client-demo/src/pages/settings/Preferences.tsx
  • web/sdk/react/components/view-container/view-container.module.css
  • web/sdk/react/components/view-container/view-container.tsx
  • web/sdk/react/index.ts
  • web/sdk/react/views-new/preferences/components/preference-row.tsx
  • web/sdk/react/views-new/preferences/components/preferences-row.module.css
  • web/sdk/react/views-new/preferences/index.ts
  • web/sdk/react/views-new/preferences/preferences-view.module.css
  • web/sdk/react/views-new/preferences/preferences-view.tsx
📝 Walkthrough

Walkthrough

The PR upgrades React to version 19, adds a new settings management flow with nested routes for organization general and preference configuration, introduces reusable UI components (ImageUpload, ViewContainer, ViewHeader), updates SDK dependencies and exports, and adds corresponding view implementations and styling.

Changes

Cohort / File(s) Summary
React 19 Upgrade
web/apps/client-demo/package.json, web/sdk/package.json
Updated React and React-DOM from v18 to v19; updated TypeScript type definitions; shifted from @stitches/react to @base-ui/react for styling foundation; added @raystack/apsara-v1 as new dependency.
Settings Routes & Navigation
web/apps/client-demo/src/Router.tsx, web/apps/client-demo/src/pages/Home.tsx, web/apps/client-demo/src/styles.css, web/apps/client-demo/src/App.tsx
Added nested route structure under /:orgId/settings with child routes for general and preferences; updated Home page to link to new settings UI; added CSS reset for body margins/padding; imported new stylesheet dependencies.
Settings Layout & Pages
web/apps/client-demo/src/pages/Settings.tsx, web/apps/client-demo/src/pages/settings/General.tsx, web/apps/client-demo/src/pages/settings/Preferences.tsx
Introduced Settings parent component managing organization context and navigation sidebar; added General settings page with delete callback integration; added Preferences page rendering PreferencesView.
Reusable UI Components
web/sdk/react/components/image-upload/*, web/sdk/react/components/view-container/*, web/sdk/react/components/view-header/*
Created ImageUpload component with file selection, canvas-based crop dialog, and JPEG export; created ViewContainer wrapper with configurable content layout; created ViewHeader with title/description display and right-aligned slot.
Settings Views & Dialogs
web/sdk/react/views-new/general/*, web/sdk/react/views-new/preferences/*
Implemented GeneralView with form-based organization title/name/avatar editing, mutation handling, and delete dialog integration; implemented PreferencesView with theme selection and newsletter subscription controls; created DeleteOrganizationDialog with confirmation and protobuf-based deletion mutation; created PreferenceRow component for preference item layout.
Styling & CSS Modules
web/sdk/react/components/.../\\*.module.css, web/sdk/react/views-new/.../\\*.module.css
Added CSS modules for image upload layout/behavior, view container spacing, delete confirmation button, general view sections, and preference row separators.
SDK Configuration & Exports
web/sdk/react/index.ts, web/sdk/package.json, web/sdk/tsup.config.ts, web/sdk/admin/components/SheetFooter.tsx
Extended React SDK exports to include new components and views; removed css prop from SheetFooter and updated border styling to design-system variable; added react-dom to external build dependencies.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

  • refactor: remove all instances of react-router-dom #1410 — Conflicts with main PR's routing approach: adds react-router-dom Link/Navigate/Outlet patterns while that PR removes router dependencies and replaces with callback-based navigation.
  • feat: move sdk billing #1425 — Directly related: both PRs expose GeneralView, PreferencesView, and DeleteOrganizationDialog components in SDK exports and introduce the same settings view implementations.
  • feat: move sdk general #1414 — Related: both PRs modify GeneralView and delete-organization-dialog implementations, sharing responsibility for the organization settings deletion UI and callbacks.

Suggested reviewers

  • rsbh
  • rohilsurana
  • paanSinghCoder

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty changed the base branch from main to feat-general-revamp March 27, 2026 08:06
@rohanchkrabrty rohanchkrabrty added the Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals. label Mar 27, 2026
@rohanchkrabrty rohanchkrabrty changed the title feat: profile settings revamp feat: preferences settings revamp Mar 27, 2026
Base automatically changed from feat-general-revamp to main April 2, 2026 09:00
@rohanchkrabrty rohanchkrabrty removed the Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals. label Apr 2, 2026
@rohanchkrabrty rohanchkrabrty enabled auto-merge (squash) April 6, 2026 04:41
@rohanchkrabrty rohanchkrabrty merged commit 5ef3fbe into main Apr 6, 2026
8 checks passed
@rohanchkrabrty rohanchkrabrty deleted the feat-profilw-revamp branch April 6, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants