StepColormap: inclusive lower bound#141
Merged
Conengmo merged 4 commits intopython-visualization:mainfrom Oct 4, 2023
Merged
Conversation
Member
Author
|
@MxMartin I know it's been a while, but are you available to comment whether this fixes your issue? |
|
@Conengmo Yes, for 'StepColormap' it does as far as my tests go |
Member
Author
|
Great, let's get this out then. Thanks for bringing this issue up and looking into it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote some simple tests to verify #134.
Found that the LinearColormap already works as expected.
Stepcolormap is not exactly broken at the moment, but weird in that the lower value of each bound is exclusive. Confusing, because the first value in the index is inclusive. And it's probably more conventional to have the lower value be inclusive and the upper value be exclusive.
I've made a new PR over #134 because these tests are important, we don't have to change LinearColormap, the change to StepColormap is smaller and updated the docstring.