fix calculation of color index#134
Closed
MxMartin wants to merge 2 commits intopython-visualization:mainfrom
Closed
fix calculation of color index#134MxMartin wants to merge 2 commits intopython-visualization:mainfrom
MxMartin wants to merge 2 commits intopython-visualization:mainfrom
Conversation
current code get the index of the color corresponding to a certain value retuned unexpected value, e.g. for index = [0, 1, 2] and value 1, the color at index 0 was returned, not index 1
for more information, see https://pre-commit.ci
Member
|
Superseded by #141 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code returns erroneous colors.
To make it clear I took the current implementation and put it into a separate function
returns:
you will notice that for value
2the current implementation would return color0, even though value2is at index1inindex.Or for
this returns
i.e. for index
4we get color0and for index5color2. Color1is never returned though it should be returned vor value4Last but not least I added a check on init to make sure the index is in order