require extensions in imports - #4876
Merged
Merged
Conversation
| } | ||
|
|
||
| // try to get cache values from 'response.ext.prebid.cache' | ||
| // try to get cache values from 'response.ext.prebid.cache.js' |
Contributor
There was a problem hiding this comment.
is this change necessary?
Collaborator
Author
There was a problem hiding this comment.
nope, that was an accidental catch by the regex replace
| @@ -1,8 +1,7 @@ | |||
| import 'mocha/mocha'; | |||
Collaborator
There was a problem hiding this comment.
Guessing this is an unused import
Collaborator
Author
There was a problem hiding this comment.
I sure hope so, I can't imagine what it would be doing where it'd need to be included only for its side-effects... either way I removed it and the tests still passed so... good?
Contributor
|
Looks good to me, but please check the failing CI Job. |
robertrmartinez
self-requested a review
February 19, 2020 22:07
robertrmartinez
approved these changes
Feb 19, 2020
robertrmartinez
left a comment
robertrmartinez
left a comment
Collaborator
There was a problem hiding this comment.
Couldn't find any glaring issues LGTM!
Tests working is a good sign and we can do some other verifications no other errors thrown in the console when loading the entire bundle.
Thanks Rich!
10 tasks
2 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Explicitly require extensions on imports and validate with eslint plugin.
Other information
This should fix any issues with dependent projects including Prebid.js that don't have the default extensions as part of the module resolver as described in #4856