NextRoll Bidder Adapter - #4829
Merged
Merged
Conversation
* Add age check before fastbid eval * Fix linting
* Add date exists check * Remove logging statement
* remove loadExternalScript function * add adroll to the adloader whitelist
* Handle nextroll id * Remove double nesting in user obj * Revert change to publisherTagAvailable
Old repo changes
Improve coverage of tests
Add docs
|
This pull request introduces 1 alert when merging a9b93dd into 1964f27 - view on LGTM.com new alerts:
|
added 7 commits
February 10, 2020 10:36
jaiminpanchal27
requested changes
Feb 25, 2020
jaiminpanchal27
left a comment
jaiminpanchal27
left a comment
Collaborator
There was a problem hiding this comment.
@abijr Request minor changes.
| let utilsMock; | ||
| beforeEach(function () { | ||
| // Remove to avoid side effects | ||
| localStorage.removeItem(PUBTAG_LOCAL_STORAGE_KEY); |
Collaborator
There was a problem hiding this comment.
Where are you trying to set these ? I did not find any localstorage usage anywhere
| return cs ? cs.s : 'unknown'; | ||
| } | ||
|
|
||
| function _parseUrl(url) { |
Collaborator
There was a problem hiding this comment.
Can you use functions from https://github.com/prebid/Prebid.js/blob/master/src/url.js
| * @param {ServerResponse[]} serverResponses List of server's responses. | ||
| * @return {UserSync[]} The user syncs which should be dropped. | ||
| */ | ||
| getUserSyncs: function (syncOptions, serverResponses, gdprConsent) { |
Collaborator
There was a problem hiding this comment.
You can remove this function if you don't need to do user sync
| @@ -0,0 +1,234 @@ | |||
| import * as utils from '../src/utils'; | |||
Collaborator
There was a problem hiding this comment.
Can you update to add 'js' extension to all imports. We recently did a change here #4876
…url.parse function
Rename imports; Remove getUserSync function; Remove unused code
Contributor
Author
|
Thank you @jaiminpanchal27! We've addressed the change request. Please let us know if there are any issues 😃 |
jaiminpanchal27
approved these changes
Feb 26, 2020
monofonik
pushed a commit
to playground-xyz/Prebid.js
that referenced
this pull request
Feb 26, 2020
* First implementation of the AdRoll adapter (#1) * Fix request and bid id (#5) * Send Zone ID (#6) * Add age check before fastbid eval (#7) * Add age check before fastbid eval * Fix linting * Add date check (#8) * Add date exists check * Remove logging statement * Fix bidRequest validation (#9) * Fix deprecated function usage (#10) * [SENG-2757] remove custom function from adapter (#11) * remove loadExternalScript function * add adroll to the adloader whitelist * Handle nextroll id (#12) * Handle nextroll id * Remove double nesting in user obj * Revert change to publisherTagAvailable * Rename adroll -> nextroll (prebid#14) * Rename fastbid -> pubtag functions and variables (prebid#15) * Improve coverage of tests * Add docs * Add docs * Improve sizes and add sellerid * Add maintainer email * Fix CI problem * Fix IE tests * Replace second instance of find * Fix types used in the doc Match prebid/prebid.github.io#1796 * Remove unused fields in spec * Add ccpa support * Remove external script usage * Remove IP field * Remove pubtag key * Rename imports; Remove getUserSync function; Remove unused code; Use url.parse function Co-authored-by: Juan Bono <juanbono94@gmail.com> Co-authored-by: Ricardo Azpeitia Pimentel <ricardo.azpeitia@nextroll.com>
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
* First implementation of the AdRoll adapter (#1) * Fix request and bid id (#5) * Send Zone ID (#6) * Add age check before fastbid eval (#7) * Add age check before fastbid eval * Fix linting * Add date check (#8) * Add date exists check * Remove logging statement * Fix bidRequest validation (#9) * Fix deprecated function usage (#10) * [SENG-2757] remove custom function from adapter (#11) * remove loadExternalScript function * add adroll to the adloader whitelist * Handle nextroll id (#12) * Handle nextroll id * Remove double nesting in user obj * Revert change to publisherTagAvailable * Rename adroll -> nextroll (#14) * Rename fastbid -> pubtag functions and variables (#15) * Improve coverage of tests * Add docs * Add docs * Improve sizes and add sellerid * Add maintainer email * Fix CI problem * Fix IE tests * Replace second instance of find * Fix types used in the doc Match prebid/prebid.github.io#1796 * Remove unused fields in spec * Add ccpa support * Remove external script usage * Remove IP field * Remove pubtag key * Rename imports; Remove getUserSync function; Remove unused code; Use url.parse function Co-authored-by: Juan Bono <juanbono94@gmail.com> Co-authored-by: Ricardo Azpeitia Pimentel <ricardo.azpeitia@nextroll.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
Other information
Documentation PR: prebid/prebid.github.io#1796