Skip to content

Experimental: use microbundled react-cytoscapejs#2133

Closed
akx wants to merge 1 commit into
plotly:devfrom
akx:microbundled-react-cytoscapejs
Closed

Experimental: use microbundled react-cytoscapejs#2133
akx wants to merge 1 commit into
plotly:devfrom
akx:microbundled-react-cytoscapejs

Conversation

@akx

@akx akx commented Jul 14, 2022

Copy link
Copy Markdown

As requested by @alexcjohnson in plotly/react-cytoscapejs#99 (comment) , this pulls in the plotly/react-cytoscapejs#99 version of react-cytoscapejs and adds cytoscape as a direct dependency (as it is a peer dependency of react-cytoscapejs going forward) for dash-renderer's dev tools.

  • 👉 This PR should not be merged as-is, though, since the package.json specifier for react-cytoscapejs is not a published version

Contributor Checklist

  • I have run **npm run test in dash/dash-renderer locally and it passed with flying colors.
  • I have run manual tests with this version of dash linked in to a downstream project:

I tried things out in my dash-cytoscape plotly/dash-cytoscape#180 branch with

pip install -e ../dash
pip install -e ../dash/components/dash-table/
pip install -e ../dash/components/dash-html-components/
pip install -e ../dash/components/dash-core-components/

and e.g. the python usage-responsive-graph.py demo shows the callback graph just fine.

@akx
akx requested a review from alexcjohnson as a code owner July 14, 2022 10:13
@akx
akx marked this pull request as draft July 14, 2022 10:13
@akx
akx force-pushed the microbundled-react-cytoscapejs branch from 3e47243 to 93ccaa5 Compare July 14, 2022 11:14
@akx

akx commented Sep 3, 2022

Copy link
Copy Markdown
Author

Closing in favor of #2217.

@akx akx closed this Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant