Skip to content

Experimental: microbundled react-cytoscapejs - #180

Closed
akx wants to merge 2 commits into
plotly:masterfrom
akx:microbundled-react-cytoscapejs
Closed

Experimental: microbundled react-cytoscapejs#180
akx wants to merge 2 commits into
plotly:masterfrom
akx:microbundled-react-cytoscapejs

Conversation

@akx

@akx akx commented Jul 14, 2022

Copy link
Copy Markdown

About

As requested by @alexcjohnson in plotly/react-cytoscapejs#99 (comment) , this pulls in the plotly/react-cytoscapejs#99 version of react-cytoscapejs and adds cytoscape as a direct dependency (as it is a peer dependency of react-cytoscapejs going forward).

I ran npm run build:all and tried some of the demos/ – everything seems to work just fine.

  • 👉 This PR should not be merged as-is, though, since the package.json specifier for react-cytoscapejs is not a published version. (That's why this is left as a draft.)

Description of changes

Please see above.

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Reference Issues

@akx

akx commented Sep 5, 2022

Copy link
Copy Markdown
Author

Merged in plotly/react-cytoscapejs#99.

@akx akx closed this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant