Conversation
Member
Author
|
Looks like it pulls the homebrew release binary directly from GitHub |
… let dep resolve the proper revision (and put it in the .lock)
grayside
reviewed
Oct 25, 2017
build.sh
Outdated
|
|
||
| go get github.com/tools/godep | ||
| go get github.com/mitchellh/gox | ||
| go get -u github.com/golang/dep/... |
Contributor
There was a problem hiding this comment.
What do the 3 dots indicate? Shouldn't we be specifying a specific version?
grayside
reviewed
Oct 25, 2017
|
|
||
| [[constraint]] | ||
| name = "github.com/fatih/color" | ||
| version = "1.5.0" |
Contributor
There was a problem hiding this comment.
Some of these versions are specific, is that on purpose vs. branches?
grayside
approved these changes
Oct 25, 2017
Contributor
grayside
left a comment
grayside
left a comment
There was a problem hiding this comment.
Approving, but added a non-blocking question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is built on the back of #94, so we can either push that one first and then this, or abandon that and do the work of both in this PR.
This adds GoReleaser support which does the following