Closed
Conversation
grayside
reviewed
Oct 21, 2017
Contributor
grayside
left a comment
There was a problem hiding this comment.
I don't see travis updates. There are hidden godep steps there, as well as an env var related to vendoring.
| packages = ["."] | ||
| revision = "cd8b52f8269e0feb286dfeef29f8fe4d5b397e0b" | ||
|
|
||
| [solve-meta] |
Contributor
There was a problem hiding this comment.
Not sure where it belongs, but depending readme recommends ci should use a fixed version.
Contributor
There was a problem hiding this comment.
dep readme, not depending
Member
Author
|
@grayside Updated based on feedback. Multiple dependencies did not have explicit versions, so I pinned to a revision |
Merged
|
hola friends! couple quick notes on this:
|
Contributor
|
Thanks @sdboyer ! (1) sounds good, (2) we decided to do in a follow-up if only for standards & practices, (3) Aha, that makes sense from npm/composer/etc. |
Member
Author
|
Thanks @sdboyer! Appreciate the feedback |
Member
Author
|
Moving all this work to #95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move away from Godep to dep (thanks to @sdboyer)
This is for #68