Skip to content

chore(docs): core bump, jumplinks demo fix#10993

Merged
tlabaj merged 4 commits intopatternfly:mainfrom
evwilkin:chore/10887-jumplinks-drawer-demo
Sep 24, 2024
Merged

chore(docs): core bump, jumplinks demo fix#10993
tlabaj merged 4 commits intopatternfly:mainfrom
evwilkin:chore/10887-jumplinks-drawer-demo

Conversation

@evwilkin
Copy link
Member

@evwilkin evwilkin commented Sep 13, 2024

Closes #10887
Replaces need for Core bump PR #10983

This PR:

  • Bumps Core versions to pull in Page overflow fix from fix(page): fix page main overflow patternfly#7025.
  • Updates jumplinks demo to fix offset calculations.
  • Updates jumplinks integration test.
  • Fixes incorrect test name in code editor integration test.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Sep 13, 2024

@evwilkin evwilkin requested review from a team, kmcfaul and tlabaj and removed request for a team September 13, 2024 17:52
@tlabaj tlabaj requested a review from mcoker September 16, 2024 19:57
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing a reference error in the jumplinks with drawer demo.
"ReferenceError: breadcrumbStyles is not defined"

You have to add the breadcrumbStyles import to the md file.

@evwilkin evwilkin force-pushed the chore/10887-jumplinks-drawer-demo branch from fa4c41e to bf80384 Compare September 24, 2024 18:16
@evwilkin evwilkin force-pushed the chore/10887-jumplinks-drawer-demo branch from 2b230d8 to d2e0b05 Compare September 24, 2024 18:27
@evwilkin evwilkin requested a review from tlabaj September 24, 2024 18:38
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll mention core is on prerelease.13 now. Not sure if it's worth trying to bump that in this PR or somewhere else?

@tlabaj tlabaj merged commit 260c173 into patternfly:main Sep 24, 2024
@tlabaj
Copy link
Contributor

tlabaj commented Sep 24, 2024

@mcoker I am bumping the versions in may datalist PR.

@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@8.0.0-prerelease.11
  • @patternfly/react-code-editor@6.0.0-prerelease.16
  • @patternfly/react-core@6.0.0-prerelease.16
  • @patternfly/react-docs@7.0.0-prerelease.26
  • @patternfly/react-drag-drop@6.0.0-prerelease.16
  • @patternfly/react-icons@6.0.0-prerelease.5
  • @patternfly/react-integration@6.0.0-prerelease.9
  • demo-app-ts@6.0.0-prerelease.19
  • @patternfly/react-styles@6.0.0-prerelease.4
  • @patternfly/react-table@6.0.0-prerelease.17
  • @patternfly/react-templates@6.0.0-prerelease.16
  • @patternfly/react-tokens@6.0.0-prerelease.5

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - JumpLinks - With drawer demo bugs

5 participants