Updates button info architecture to align with guidelines.#3061
Merged
mmenestr merged 3 commits intopatternfly:mainfrom Jul 18, 2022
Merged
Updates button info architecture to align with guidelines.#3061mmenestr merged 3 commits intopatternfly:mainfrom
mmenestr merged 3 commits intopatternfly:mainfrom
Conversation
Collaborator
|
PF4 preview: https://patternfly-org-pr-3061-v4.surge.sh/v4 |
mmenestr
reviewed
Jul 11, 2022
packages/v4/patternfly-docs/content/design-guidelines/components/button/button.md
Outdated
Show resolved
Hide resolved
mmenestr
reviewed
Jul 11, 2022
packages/v4/patternfly-docs/content/design-guidelines/components/button/button.md
Outdated
Show resolved
Hide resolved
mmenestr
reviewed
Jul 11, 2022
packages/v4/patternfly-docs/content/design-guidelines/components/button/button.md
Outdated
Show resolved
Hide resolved
mmenestr
reviewed
Jul 11, 2022
packages/v4/patternfly-docs/content/design-guidelines/components/button/button.md
Outdated
Show resolved
Hide resolved
mmenestr
reviewed
Jul 11, 2022
packages/v4/patternfly-docs/content/design-guidelines/components/button/button.md
Outdated
Show resolved
Hide resolved
mmenestr
reviewed
Jul 11, 2022
packages/v4/patternfly-docs/content/design-guidelines/components/button/button.md
Outdated
Show resolved
Hide resolved
mmenestr
requested changes
Jul 11, 2022
Collaborator
mmenestr
left a comment
mmenestr
left a comment
There was a problem hiding this comment.
Overall looks good! Just left a few comments - and also want to add that half the images seem to not show up. Not sure why that's the case - maybe there' not in the folder, or there's a formatting issue but I would just double check all the images in the previews!
You can see the website preview using this link: https://patternfly-org-pr-3061-v4.surge.sh/v4/components/button/design-guidelines
Collaborator
Author
|
@mmenestr made those changes! can you let me know how the images look? I was still able to see them even with the preview link you sent, but maybe I'm missing something. |
mmenestr
reviewed
Jul 18, 2022
packages/v4/patternfly-docs/content/design-guidelines/components/button/button.md
Outdated
Show resolved
Hide resolved
mmenestr
reviewed
Jul 18, 2022
packages/v4/patternfly-docs/content/design-guidelines/components/button/button.md
Outdated
Show resolved
Hide resolved
mmenestr
approved these changes
Jul 18, 2022
mcarrano
added a commit
to mcarrano/patternfly-org
that referenced
this pull request
Jul 19, 2022
…nto text-input-group * 'main' of https://github.com/patternfly/patternfly-org: (170 commits) chore(release): releasing packages [ci skip] Updates button info architecture to align with guidelines. (patternfly#3061) Card design guideline changes. (patternfly#3087) chore(release): releasing packages [ci skip] iss3078 (patternfly#3079) chore(release): releasing packages [ci skip] changing alert guidelines (patternfly#3064) chore(release): releasing packages [ci skip] mastshead (patternfly#3062) chore(release): releasing packages [ci skip] jumplink (patternfly#3051) chore(release): releasing packages [ci skip] calendar (patternfly#3058) chore(release): releasing packages [ci skip] feat(doc-framework): add dark theme toggle for full page examples (patternfly#3056) chore(release): releasing packages [ci skip] edit overflow guidelines (patternfly#3038) chore(release): releasing packages [ci skip] docs(a11y): create template for a11y docs (patternfly#3019) docs(Tooltip): add a11y docs (patternfly#2892) ... # Conflicts: # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/attribute-value-filter.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/auto-complete-search.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/text-input-elements.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/text-input-group.md
jessiehuff
pushed a commit
to jessiehuff/patternfly-org
that referenced
this pull request
Oct 24, 2022
…y#3061) * Updates button info architecture to align with guidelines. * Updates button design guidelines. * Fixes typo and moves link subsection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3059