feat(doc-framework): add dark theme toggle for full page examples#3056
Merged
mcoker merged 2 commits intopatternfly:mainfrom Jul 11, 2022
Merged
feat(doc-framework): add dark theme toggle for full page examples#3056mcoker merged 2 commits intopatternfly:mainfrom
mcoker merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
PF4 preview: https://patternfly-org-pr-3056-v4.surge.sh/v4 |
nicolethoen
reviewed
Jul 8, 2022
| hasVersionSwitcher: true, | ||
| hasDesignGuidelines: true, | ||
| hasDarkThemeSwitcher: false, | ||
| hasDarkThemeSwitcher: true, // change back before committing. DONT LET ME COMMIT THIS! |
Collaborator
There was a problem hiding this comment.
You committed this - do you mean don't merge this?
Contributor
Author
There was a problem hiding this comment.
Oops, yep! When we get an approval on the PR from @mceledonia or @mmenestr, I'll remove that.
nicolethoen
approved these changes
Jul 8, 2022
Collaborator
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
This looks great to me (after you set the config value hasDarkThemeSwitcher to false
mceledonia
approved these changes
Jul 11, 2022
mcarrano
added a commit
to mcarrano/patternfly-org
that referenced
this pull request
Jul 19, 2022
…nto text-input-group * 'main' of https://github.com/patternfly/patternfly-org: (170 commits) chore(release): releasing packages [ci skip] Updates button info architecture to align with guidelines. (patternfly#3061) Card design guideline changes. (patternfly#3087) chore(release): releasing packages [ci skip] iss3078 (patternfly#3079) chore(release): releasing packages [ci skip] changing alert guidelines (patternfly#3064) chore(release): releasing packages [ci skip] mastshead (patternfly#3062) chore(release): releasing packages [ci skip] jumplink (patternfly#3051) chore(release): releasing packages [ci skip] calendar (patternfly#3058) chore(release): releasing packages [ci skip] feat(doc-framework): add dark theme toggle for full page examples (patternfly#3056) chore(release): releasing packages [ci skip] edit overflow guidelines (patternfly#3038) chore(release): releasing packages [ci skip] docs(a11y): create template for a11y docs (patternfly#3019) docs(Tooltip): add a11y docs (patternfly#2892) ... # Conflicts: # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/attribute-value-filter.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/auto-complete-search.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/text-input-elements.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/text-input-group.md
jessiehuff
pushed a commit
to jessiehuff/patternfly-org
that referenced
this pull request
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3055