fix(deps): remove direct github.com/docker/docker dependency

[pflynn-virtru]

Summary

• Removes the direct github.com/docker/docker dependency from service/go.mod by replacing the HostConfigModifier callback in keycloak_test.go with the ContainerRequest.AutoRemove field
• docker/docker remains as an indirect dependency (pulled in by testcontainers-go) until testcontainers migrates to the new moby/moby/* modules (testcontainers/testcontainers-go#3496)
• docker/go-connections remains as a direct dependency (separate module, used for nat.Port in testcontainers API)

Context

Docker v29+ has moved to github.com/moby/moby/v2 with proper Go module support. The old github.com/docker/docker path is deprecated and won't receive updates past v28.x. A full migration is blocked by testcontainers-go, which still exposes docker/docker types in its public API. This PR is the first step, removing our own direct imports.

Test plan

• go build ./service/... passes
• golangci-lint run ./service/entityresolution/integration/... passes with 0 issues
• docker/docker confirmed as // indirect in go.mod
• CI integration tests (if Docker available)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Updated test infrastructure to configure test containers for automatic removal during test runs.
  • Cleaned up module dependency declarations by moving a container-related dependency to indirect.
  • No user-facing behavior changes; internal test and dependency maintenance only.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request initiates a transition away from the deprecated github.com/docker/docker module by removing it as a direct dependency. This change simplifies the test configuration by leveraging native fields in the testcontainers API, while maintaining necessary functionality through indirect dependency management until upstream libraries complete their own migration.

Highlights

• Dependency Management: Removed the direct dependency on github.com/docker/docker from service/go.mod, marking it as an indirect dependency instead.
• Code Refactoring: Updated keycloak_test.go to use the AutoRemove field in ContainerRequest, eliminating the need for the HostConfigModifier callback and the associated docker/docker import.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

---

The docker path is fading fast, / A legacy that cannot last. / We clean the code and trim the tree, / To keep our modules running free.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d48b3157-4821-4623-bcad-f4210b068cfc

📥 Commits

Reviewing files that changed from the base of the PR and between a9b38c8 and bbb13fd.

📒 Files selected for processing (2)

• service/entityresolution/integration/keycloak_test.go
• service/go.mod

---

📝 Walkthrough

Walkthrough

Replaced a Docker HostConfigModifier in a Keycloak test with testcontainers' AutoRemove field on ContainerRequest, and moved github.com/docker/docker v28.5.1+incompatible from direct to indirect in service/go.mod.

Changes

Cohort / File(s)	Summary
Test Container Setup service/entityresolution/integration/keycloak_test.go	Removed github.com/docker/docker/api/types/container import and the HostConfigModifier that set hostConfig.AutoRemove = true; set AutoRemove: true directly on tc.ContainerRequest.
Dependency Management service/go.mod	Moved github.com/docker/docker v28.5.1+incompatible from direct require to the // indirect block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

size/m

Suggested reviewers

• jentfoo
• c-r33d

Poem

🐰 A tiny hop, a cleaner test,
One less import, one less quest,
Containers vanish when they're through,
My code hops lighter — hooray, we do! 🎉

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the primary change: removing the direct dependency on github.com/docker/docker from the Go module. It directly reflects the main objective of the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/remove-direct-docker-dep

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request simplifies the Keycloak integration test setup by replacing the HostConfigModifier with the AutoRemove property in the container configuration. As a result, the direct dependency on github.com/docker/docker has been removed from go.mod and is now listed as an indirect dependency. I have no feedback to provide.

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	190.747198ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	92.335857ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	415.337065ms
Throughput	240.77 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	42.268649572s
Average Latency	420.134258ms
Throughput	118.29 requests/second

[github-actions]

X-Test Failure Report

test-cases-mapping-report
bats-test-results
cukes-report
opentdfplatformAE97RI.dockerbuild

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	195.096278ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	95.48421ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	380.933275ms
Throughput	262.51 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	40.832865666s
Average Latency	405.640516ms
Throughput	122.45 requests/second

[github-actions]

X-Test Results

✅ go-pull-3229
✅ java-pull-3229
✅ go-v0.9.0
✅ java-v0.9.0
✅ js-pull-3229
✅ js-v0.9.0
cukes-report
test-cases-mapping-report
bats-test-results
opentdfplatformH8PXQG.dockerbuild