fix(policy)!: only require namespace on GetAction if no id provided

[elizabethhealy]

Proposed Changes

This pull request refactors the validation logic for the GetActionRequest protobuf message. Previously, namespace fields were always required, but now they are only mandatory when an action is being retrieved by its name. This change enhances the flexibility of the API by allowing direct retrieval of actions via their ID without needing to specify a namespace, streamlining operations and improving usability.

Checklist

• I have added or updated unit tests
• I have added or updated integration tests (if appropriate)
• I have added or updated documentation

Testing Instructions

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the validation logic for the GetActionRequest protobuf message. Previously, namespace fields were always required, but now they are only mandatory when an action is being retrieved by its name. This change enhances the flexibility of the API by allowing direct retrieval of actions via their ID without needing to specify a namespace, streamlining operations and improving usability.

Highlights

• Refined Validation Logic: The validation for GetActionRequest has been updated to conditionally require namespace_id or namespace_fqn only when an action is identified by its name, not when an id is provided.
• Documentation Update: The gRPC documentation for namespace_id and namespace_fqn fields has been adjusted to accurately reflect their new conditional requirement.
• Test Case Alignment: Unit tests were modified to align with the revised validation rules, ensuring correct behavior for both successful and failing scenarios under the new logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• docs/grpc/index.html
  • Updated descriptions for namespace_id and namespace_fqn to clarify they are "Required when identifier is set to name."
• service/policy/actions/actions.proto
  • Replaced the buf.validate.message).oneof requirement with a more flexible buf.validate.message).cel expression to conditionally enforce namespace presence based on whether an id or name is provided.
  • Added (buf.validate.field).ignore = IGNORE_IF_ZERO_VALUE to namespace_id and namespace_fqn fields.
• service/policy/actions/actions_test.go
  • Added errMessageNamespaceByName constant.
  • Removed NamespaceId assignment from a successful GetActionRequest_Id test case.
  • Updated expected error messages in failing test cases to match the new validation logic, specifically changing errMessageOneof to errMessageRequired and errMessageNamespaceByName.

Ignored Files

• Ignored by pattern: docs/openapi/**/* (1)
  • docs/openapi/policy/actions/actions.openapi.yaml
• Ignored by pattern: protocol/**/* (1)
  • protocol/go/policy/actions/actions.pb.go

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

ID makes it clear, Namespace not always needed, Rules now softly bend.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies the validation for GetActionRequest to make namespace information optional when an action is fetched by its ID. The changes are reflected in the protobuf definitions, generated documentation, and unit tests. The overall logic seems correct. However, I've found a potential issue in the protobuf definition where a non-standard enum value IGNORE_IF_ZERO_VALUE is used. This could cause compilation failures or incorrect validation behavior. I've suggested using the standard IGNORE_IF_UNPOPULATED value instead.

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	202.040249ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	100.069998ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	395.975098ms
Throughput	252.54 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	42.865192587s
Average Latency	426.4584ms
Throughput	116.64 requests/second

[github-actions]

X-Test Results

✅ go-pull-3144
✅ go-v0.9.0
✅ java-pull-3144
✅ java-v0.9.0
✅ js-pull-3144
✅ js-v0.9.0
test-cases-mapping-report
bats-test-results
cukes-report
opentdfplatform9SJBJM.dockerbuild