prow: fix tide context policy collisions for 7 repos#81365
prow: fix tide context policy collisions for 7 repos#81365openshift-merge-bot[bot] merged 2 commits into
Conversation
Remove conditionally-triggered job contexts from branch-protection required_status_checks to prevent collisions with tide's required-if-present-contexts. When a context appears in both sets, GetTideContextPolicy validation fails and silently breaks tide for the entire subpool (kubernetes-sigs/prow#777). Repos fixed: certman-operator, managed-node-metadata-operator, managed-upgrade-operator, ocm-agent, ocm-agent-operator, rbac-permissions-operator, dora-metrics/pelorus. Also adds missing tide required-if-present-contexts entries for rbac-permissions-operator and dora-metrics/pelorus in _config.yaml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughThis PR updates Prow configuration for several repositories: removes several ChangesProw branch-protection and tide configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Unlike the other repos, ocm-agent's coverage, lint, and test jobs are always_run: true. The collision for this repo comes from the tide required-if-present-contexts entry, not from BP. Remove those three from required-if-present and restore them in BP where they belong. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
| required_status_checks: | ||
| contexts: | ||
| - dpulls | ||
| - ci/prow/4.13-e2e-openshift |
There was a problem hiding this comment.
conditional job - move to required-if-present-contexts
| - ci/prow/coverage | ||
| - ci/prow/lint | ||
| - ci/prow/test | ||
| - ci/prow/validate |
There was a problem hiding this comment.
| - ci/prow/coverage | ||
| - ci/prow/lint | ||
| - ci/prow/test | ||
| - ci/prow/validate |
There was a problem hiding this comment.
All conditional
Already configured
| - ci/prow/images | ||
| - ci/prow/lint | ||
| - ci/prow/test | ||
| - ci/prow/validate |
There was a problem hiding this comment.
All conditional
Already configured
| - ci/prow/images | ||
| - ci/prow/lint | ||
| - ci/prow/test | ||
| - ci/prow/validate |
There was a problem hiding this comment.
All conditional
Added to required-if-present-contexts below
| - ci/prow/coverage | ||
| - ci/prow/lint | ||
| - ci/prow/test | ||
| - ci/prow/e2e-binary-build-success |
There was a problem hiding this comment.
Only the last one is conditional
Configured as always required in
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, Prucek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@petr-muller: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* prow: fix tide context policy collisions for 7 repos Remove conditionally-triggered job contexts from branch-protection required_status_checks to prevent collisions with tide's required-if-present-contexts. When a context appears in both sets, GetTideContextPolicy validation fails and silently breaks tide for the entire subpool (kubernetes-sigs/prow#777). Repos fixed: certman-operator, managed-node-metadata-operator, managed-upgrade-operator, ocm-agent, ocm-agent-operator, rbac-permissions-operator, dora-metrics/pelorus. Also adds missing tide required-if-present-contexts entries for rbac-permissions-operator and dora-metrics/pelorus in _config.yaml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * prow: fix ocm-agent — coverage/lint/test are always_run, not conditional Unlike the other repos, ocm-agent's coverage, lint, and test jobs are always_run: true. The collision for this repo comes from the tide required-if-present-contexts entry, not from BP. Remove those three from required-if-present and restore them in BP where they belong. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Remove conditionally-triggered job contexts from branch-protection required_status_checks to prevent collisions with tide's required-if-present-contexts. When a context appears in both sets, GetTideContextPolicy validation fails and silently breaks tide for the entire subpool (kubernetes-sigs/prow#777). Follows the fix pattern from #81244.
Repos fixed: certman-operator, managed-node-metadata-operator, managed-upgrade-operator, ocm-agent, ocm-agent-operator, rbac-permissions-operator, dora-metrics/pelorus.
Also adds missing tide required-if-present-contexts entries for rbac-permissions-operator and dora-metrics/pelorus in _config.yaml.
Followup from https://redhat-internal.slack.com/archives/CBUT43E94/p1782948367195589?thread_ts=1782883307.967359&cid=CBUT43E94
There's a presubmit that's supposed to catch this via checkconfig - but checkconfig is broken. kubernetes-sigs/prow#791 shoudl fix it. With fixed checkconfig we get the following output:
I fed that to a Claude to fix this, which did #81365. When run against that branch, the fixed checkconfig passes:
🤖 Generated with Claude Code
Summary by CodeRabbit
This PR updates Prow and Tide configuration for several OpenShift component repositories to avoid context policy collisions that can break Tide validation. In practice, it removes overlapping Prow status checks from branch protection where those jobs are already handled by Tide’s
required-if-present-contexts, reducing the risk of subpool-wide Tide failures.It also adds missing Tide context entries for
rbac-permissions-operatoranddora-metrics/pelorus, and adjustsocm-agentso its always-run coverage, lint, and test checks remain enforced through branch protection instead of being treated as optional-if-present. As a result, CI requirements are now aligned more cleanly across branch protection and Tide for the affected repositories.