Remove duplicate Tide contexts for rbac-permissions-operator#81341
Conversation
After openshift/rbac-permissions-operator/_prowconfig.yaml hard-requires prow presubmit contexts, listing the same contexts under required-if-present-contexts in _config.yaml makes Tide fail context checker setup for otherwise mergeable PRs. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughUpdated the tide.context_options configuration for the openshift/pagerduty-operator repository in the Prow config file, removing one entry from required-if-present-contexts and removing the skip-unknown-contexts setting. ChangesTide Configuration Update
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hector-vido, MitaliBhalla The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@MitaliBhalla: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@MitaliBhalla: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
rbac-permissions-operatorrequired-if-present-contextsfromcore-services/prow/02_config/_config.yaml.skip-unknown-contexts: trueand the hard-required contexts inopenshift/rbac-permissions-operator/_prowconfig.yaml.After #80705, prow presubmit contexts are hard-required in the repo
_prowconfig.yaml. Leaving the same contexts in globalrequired-if-present-contextsmakes Tide fail context checker setup:This blocks otherwise mergeable PRs on openshift/rbac-permissions-operator (e.g. dependency automerge PRs with
lgtm+approvedand green checks).Test plan
_prowconfig.yamlbranch protectionMade with Cursor
Summary by CodeRabbit
This change updates global Tide context handling for
openshift/rbac-permissions-operatorso its CI checks are no longer treated as both hard-required andrequired-if-presentat the same time. In practice, that removes the context checker conflict that was blocking Tide from accepting otherwise mergeable PRs for this repository, while still keeping the repository’s required checks enforced through its own_prowconfig.yaml.The repo-level
skip-unknown-contexts: truebehavior remains in place, preserving the existing CI gating model without the conflicting global context entry.