Skip to content

Remove duplicate Tide contexts for rbac-permissions-operator#81341

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
MitaliBhalla:rosa-745-rbac-remove-duplicate-tide-contexts
Jul 1, 2026
Merged

Remove duplicate Tide contexts for rbac-permissions-operator#81341
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
MitaliBhalla:rosa-745-rbac-remove-duplicate-tide-contexts

Conversation

@MitaliBhalla

@MitaliBhalla MitaliBhalla commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove rbac-permissions-operator required-if-present-contexts from core-services/prow/02_config/_config.yaml.
  • Keep repo-level skip-unknown-contexts: true and the hard-required contexts in openshift/rbac-permissions-operator/_prowconfig.yaml.

After #80705, prow presubmit contexts are hard-required in the repo _prowconfig.yaml. Leaving the same contexts in global required-if-present-contexts makes Tide fail context checker setup:

error setting up context checker for pr N: contexts ci/prow/coverage, ci/prow/e2e-binary-build-success, ci/prow/lint, ci/prow/test, ci/prow/validate are defined as required and required if present

This blocks otherwise mergeable PRs on openshift/rbac-permissions-operator (e.g. dependency automerge PRs with lgtm + approved and green checks).

Test plan

  • Tide pools openshift/rbac-permissions-operator PRs again after merge
  • Required checks still enforced via _prowconfig.yaml branch protection

Made with Cursor

Summary by CodeRabbit

This change updates global Tide context handling for openshift/rbac-permissions-operator so its CI checks are no longer treated as both hard-required and required-if-present at the same time. In practice, that removes the context checker conflict that was blocking Tide from accepting otherwise mergeable PRs for this repository, while still keeping the repository’s required checks enforced through its own _prowconfig.yaml.

The repo-level skip-unknown-contexts: true behavior remains in place, preserving the existing CI gating model without the conflicting global context entry.

After openshift/rbac-permissions-operator/_prowconfig.yaml hard-requires
prow presubmit contexts, listing the same contexts under
required-if-present-contexts in _config.yaml makes Tide fail context
checker setup for otherwise mergeable PRs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c49dff4c-5346-4ed3-897e-d7e28602c05f

📥 Commits

Reviewing files that changed from the base of the PR and between 842e4b4 and 35b631f.

📒 Files selected for processing (1)
  • core-services/prow/02_config/_config.yaml
💤 Files with no reviewable changes (1)
  • core-services/prow/02_config/_config.yaml

Walkthrough

Updated the tide.context_options configuration for the openshift/pagerduty-operator repository in the Prow config file, removing one entry from required-if-present-contexts and removing the skip-unknown-contexts setting.

Changes

Tide Configuration Update

Layer / File(s) Summary
Remove context and skip-unknown-contexts setting
core-services/prow/02_config/_config.yaml
Removes ci/prow/e2e-binary-build-success from required-if-present-contexts and deletes skip-unknown-contexts: true for the pagerduty-operator repo block.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing duplicate Tide contexts for rbac-permissions-operator.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes prow config YAML; no test files or Ginkgo titles are touched, so there are no dynamic/stable-name issues.
Test Structure And Quality ✅ Passed PR only updates prow YAML; no Ginkgo test code or test behavior was changed, so the test-quality checklist is not applicable.
Microshift Test Compatibility ✅ Passed PR only edits prow YAML context config; no new Ginkgo e2e tests or test code were added, so MicroShift compatibility isn’t implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only edits prow config YAML; no Ginkgo e2e tests were added or modified, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only Prow Tide config changed; no deployment manifests, operator code, or controllers were added or modified, and no scheduling/topology constraints were introduced.
Ote Binary Stdout Contract ✅ Passed Change is YAML-only Tide config; no main/init/TestMain/suite setup or stdout logging code was added or altered.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only changes prow YAML config and contains no IPv4 or external-connectivity code.
No-Weak-Crypto ✅ Passed Touched file is Prow YAML config only; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret/token comparison patterns found.
Container-Privileges ✅ Passed No changed file in the PR diff adds privileged/root/network-escape settings; exact privilege-marker scan found zero hits.
No-Sensitive-Data-In-Logs ✅ Passed The PR only changes Prow YAML context config; no log statements or sensitive data exposures are introduced in the touched file.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from droslean and psalajova July 1, 2026 14:11
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 1, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@MitaliBhalla: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@hector-vido

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2026
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hector-vido, MitaliBhalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2026
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@MitaliBhalla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit bfa1c4a into openshift:main Jul 1, 2026
12 checks passed
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@MitaliBhalla: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • config configmap in namespace ci at cluster core-ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
Details

In response to this:

Summary

  • Remove rbac-permissions-operator required-if-present-contexts from core-services/prow/02_config/_config.yaml.
  • Keep repo-level skip-unknown-contexts: true and the hard-required contexts in openshift/rbac-permissions-operator/_prowconfig.yaml.

After #80705, prow presubmit contexts are hard-required in the repo _prowconfig.yaml. Leaving the same contexts in global required-if-present-contexts makes Tide fail context checker setup:

error setting up context checker for pr N: contexts ci/prow/coverage, ci/prow/e2e-binary-build-success, ci/prow/lint, ci/prow/test, ci/prow/validate are defined as required and required if present

This blocks otherwise mergeable PRs on openshift/rbac-permissions-operator (e.g. dependency automerge PRs with lgtm + approved and green checks).

Test plan

  • Tide pools openshift/rbac-permissions-operator PRs again after merge
  • Required checks still enforced via _prowconfig.yaml branch protection

Made with Cursor

Summary by CodeRabbit

This change updates global Tide context handling for openshift/rbac-permissions-operator so its CI checks are no longer treated as both hard-required and required-if-present at the same time. In practice, that removes the context checker conflict that was blocking Tide from accepting otherwise mergeable PRs for this repository, while still keeping the repository’s required checks enforced through its own _prowconfig.yaml.

The repo-level skip-unknown-contexts: true behavior remains in place, preserving the existing CI gating model without the conflicting global context entry.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants