Skip to content

travis: update go versions#487

Merged
liangchenye merged 1 commit intoopencontainers:masterfrom
dvrkps:patch-2
Oct 9, 2017
Merged

travis: update go versions#487
liangchenye merged 1 commit intoopencontainers:masterfrom
dvrkps:patch-2

Conversation

@dvrkps
Copy link
Copy Markdown
Contributor

@dvrkps dvrkps commented Sep 27, 2017

Signed-off-by: Davor Kapsa davor.kapsa@gmail.com

@wking
Copy link
Copy Markdown
Contributor

wking commented Sep 27, 2017

PullApprove is still not happy, because your Signed-off-by email does not match your author.

$ git show origin/pr/487 | head -n7
commit e4f37c26dc089b5914aba6112bc241e8341de5cb
Author: Davor Kapsa <dvrkps@users.noreply.github.com>
Date:   Wed Sep 27 12:38:47 2017 +0200

    travis: update go versions
    
    Signed-off-by: Davor Kapsa <davor.kapsa@gmail.com>

I still think the easiest fix would be to allow edits from maintainers for this PR, and then they can fix it for you ;).

@dvrkps
Copy link
Copy Markdown
Contributor Author

dvrkps commented Sep 27, 2017

@wking "Allow edits from maintainers." is checked by default. IMHO

@Mashimiao
Copy link
Copy Markdown

I think we can't edit the commit's author

@dvrkps
Copy link
Copy Markdown
Contributor Author

dvrkps commented Sep 28, 2017

@Mashimiao @wking I set my email address to public.
Can anybody trigger sign-off-by check again?

@wking
Copy link
Copy Markdown
Contributor

wking commented Sep 28, 2017

I think we can't edit the commit's author

Bummer. It sounded like you could force-push to patch-2 in https://github.com/dvrkps/runtime-tools.git, after a local git commit --amend --author '...' --no-edit.

Signed-off-by: Davor Kapsa <davor.kapsa@gmail.com>
@Mashimiao
Copy link
Copy Markdown

@wking Oh, I haven't used such funciton. @dvrkps re-edit your author's email, I think problem has been solved.

@dvrkps
Copy link
Copy Markdown
Contributor Author

dvrkps commented Sep 29, 2017

@Mashimiao re-edit as back to hiden email address ?

@Mashimiao
Copy link
Copy Markdown

I modified the author's email of this commit to be the same as signed-off-by, davor.kapsa@gmail.com

@wking
Copy link
Copy Markdown
Contributor

wking commented Sep 29, 2017 via email

@Mashimiao
Copy link
Copy Markdown

Mashimiao commented Oct 9, 2017

LGTM

Approved with PullApprove

1 similar comment
@liangchenye
Copy link
Copy Markdown
Member

liangchenye commented Oct 9, 2017

LGTM

Approved with PullApprove

@liangchenye liangchenye merged commit c1aa987 into opencontainers:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants