travis: update go versions#482
Closed
dvrkps wants to merge 2 commits intoopencontainers:masterfrom
dvrkps:patch-1
Closed
travis: update go versions#482dvrkps wants to merge 2 commits intoopencontainers:masterfrom dvrkps:patch-1
dvrkps wants to merge 2 commits intoopencontainers:masterfrom
dvrkps:patch-1
Conversation
Member
Contributor
|
The Signed-off-by needs to go on all the commits. With fc42d47 you have: Also, PullApprove has had problems in the past with Signed-off-by email addresses that don't match the Author email address. So I think you want to squash down to a single commit where your author/committer email address matches your Signed-off-by address. If you need some help with the Git, you can probably allow edits from maintainers and one of them can straighten out your branch. |
Contributor
Author
|
I open #487 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.