[codex] Apply managed new-thread defaults in TUI#29916
Closed
hefuc-oai wants to merge 1 commit into
Closed
Conversation
hefuc-oai
force-pushed
the
codex/managed-new-thread-model-default
branch
from
74f4b29 to
24bdeb4
Compare
hefuc-oai
force-pushed
the
codex/tui-managed-new-thread-model-default
branch
from
6f3e7dd to
6d6e1c8
Compare
hefuc-oai
force-pushed
the
codex/tui-managed-new-thread-model-default
branch
from
6d6e1c8 to
9bac348
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
models.new_threaddefaults before rendering and starting fresh TUI threadscodex --modeland-claunch overrides/newwhile leaving resume and fork flows unchangedWhy
The TUI starts from an already merged
Config, so a model persisted inconfig.tomlwas forwarded throughthread/startas though it were an explicit per-thread choice. That prevented the managed new-thread default from becoming the initial TUI selection.This keeps the precedence explicit launch choice > managed new-thread default > persisted user default, matching the App behavior.
Depends on #29683.
Validation
just test -p codex-tui managed_new_thread_defaults::testsjust test -p codex-tui fresh_session_config_uses_managed_new_thread_model_defaultjust test -p codex-tui fresh_session_config_uses_current_service_tierjust test -p codex-tui— 2,939 passed; two unrelated guardian feature-flag tests failed identically on the base branchjust fix -p codex-tuijust fmt