[codex] Add managed new-thread model settings#29683
Conversation
hefuc-oai
force-pushed
the
codex/managed-new-thread-model-default
branch
from
7872e98 to
f35ecbe
Compare
hefuc-oai
changed the title
hefuc-oai
force-pushed
the
codex/managed-new-thread-model-default
branch
from
0e65a6c to
601e010
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
hefuc-oai
force-pushed
the
codex/managed-new-thread-model-default
branch
from
74f4b29 to
24bdeb4
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24bdeb4546
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
shijie-oai
left a comment
shijie-oai
left a comment
There was a problem hiding this comment.
From my perspective looks good but I am not an expert in rust.
hefuc-oai
force-pushed
the
codex/managed-new-thread-model-default
branch
from
0f3877f to
0f2bf04
Compare
hefuc-oai
force-pushed
the
codex/managed-new-thread-model-default
branch
from
0f2bf04 to
4356bf6
Compare
3 participants
Why
Admins need persistent defaults for the model, reasoning effort, and service tier shown when the Desktop App creates a new thread. These are initialization defaults rather than runtime constraints: the App should use them to initialize its draft while still allowing a user to make an explicit selection.
The app-server therefore needs to expose the managed values before thread creation without changing
thread/startbehavior for other clients.What changed
model,model_reasoning_effort, andservice_tierfrom[models.new_thread]inrequirements.toml.modelsrequirements through the existing requirements-layer precedence rules.configRequirements/readasrequirements.models.newThread.configRequirements/readfields in the app-server README.Scope
This PR is data plumbing only. It does not apply these values during
thread/startand does not change thread creation for existing app-server clients, resumed or forked sessions, internal or subagent sessions,codex exec, or the TUI. A companion Desktop App change owns draft initialization, sends the effective settings for ordinary and prewarmed starts, and preserves explicit user changes.Validation
[models.new_thread]configRequirements/readintegration coverage