Add workspace messages app-server API#29001
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc289a4e79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
One thing to confirm: should failures on this endpoint be user-visible JSON-RPC errors, or should we treat workspace messages as best-effort and return an empty response? |
## Summary - Add `workspace-headline` as a configurable TUI status-line item. - Show the active workspace headline for eligible ChatGPT/Codex backend sessions. - Refresh through app-server every 10 seconds so admin headline changes appear during the session, while omitting empty or feature-disabled results. ## Testing - `just test -p codex-tui workspace_headline` - `just test -p codex-tui status_line_setup` - `just fix -p codex-tui` - `just fmt` ## Stack - Depends on #29001 for the workspace-messages app-server API.
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
account/workspaceMessages/readmethod, generated schemas, and README documentation.featureEnabled: false.Testing
just write-app-server-schemajust test -p codex-backend-clientjust test -p codex-app-server-protocoljust test -p codex-app-server workspace_messagesjust fix -p codex-backend-client -p codex-app-server-protocol -p codex-app-serverjust fmtStack