Add workspace headline statusline item#28232
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96075b79ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub created_at: Option<String>, | ||
| pub archived_at: Option<String>, |
There was a problem hiding this comment.
Use Unix-second timestamps for workspace messages
These v2 response fields generate createdAt/archivedAt as strings, but app-server timestamps are expected to be Unix-second i64 values, so clients get a timestamp shape inconsistent with the API contract. Please parse/map the backend timestamps before returning them. guidance
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| impl CodexWorkspaceMessagesResponse { | ||
| pub fn headlines(&self) -> impl Iterator<Item = &CodexWorkspaceMessage> { |
There was a problem hiding this comment.
Keep workspace-message filters private
These new public headlines/announcements helpers are only exercised by the unit test and no production caller uses them, so they expand the codex-backend-client API solely for test convenience. Please keep the filtering local/private until a real caller needs it. guidance
Useful? React with 👍 / 👎.
96075b7 to
3f58599
Compare
3f58599 to
c29327c
Compare
db4df7b to
ffe6e58
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88a6fdb44a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c7a1d9971
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2747b96
into
xli-codex/workspace-messages-app-server
Summary
workspace-headlineas a configurable TUI status-line item.Testing
just test -p codex-tui workspace_headlinejust test -p codex-tui status_line_setupjust fix -p codex-tuijust fmtStack