PAC 3 - Add Windows system proxy resolver#26708
Conversation
6fcd2bd to
c1f900e
Compare
4cc962b to
a55b700
Compare
c1f900e to
86815bc
Compare
216cb3f to
2777480
Compare
4ffc2f4 to
968f40d
Compare
c02c09b to
847b03a
Compare
1eebefb to
a9bed73
Compare
847b03a to
da0445f
Compare
iceweasel-oai
left a comment
There was a problem hiding this comment.
(from Codex): Added inline review comments.
a9bed73 to
9a9be5d
Compare
47a7061 to
8a2b646
Compare
ca6d44e to
7d9743d
Compare
d1af2f3 to
30866d1
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30866d153a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
008144e to
fa620b3
Compare
5497d3d to
354094e
Compare
e74fc31 to
a2f4da6
Compare
d44ee4e to
5dd5bac
Compare
a2f4da6 to
860d6e5
Compare
5dd5bac to
2243326
Compare
2e71f40 to
c590f10
Compare
c590f10 to
13cc356
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13cc356ec8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c33069fc0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Stacked on #26707.
Adds the Windows implementation of the shared system-proxy contract. This allows Codex-owned auth clients to use the route Windows selects for each auth URL, including explicit PAC configuration, WPAD auto-detection, static proxies, and bypass rules.
The
respect_system_proxyfeature is disabled by default, so existing client behavior remains unchanged unless explicitly enabled.Implementation
codex-clientdependencies:windows-syswithWin32_FoundationandWin32_Networking_WinHttp;sha2for redacted cache keys.outbound_proxy/windows.rson Windows.WinHttpGetIEProxyConfigForCurrentUser.WinHttpGetProxyForUrlfor PAC/WPAD and maps results into the sharedSystemProxyDecision::{Direct, Proxy, Unavailable}contract.DIRECT,PROXY,HTTPS, and keyed static proxy entries.<local>and host, suffix, wildcard, and port matching.GlobalFreeand closes sessions withWinHttpCloseHandle.End-user behavior
[features.respect_system_proxy]:DIRECTdecisions use a direct connection;DIRECT, through the shared contract from PAC 2 - Add shared auth system proxy contract #26707.Tests
Adds coverage for:
PROXY proxy.internal:8080andHTTPS proxy.internal:8443;DIRECTand unsupported proxy-token behavior;<local>, wildcard, suffix, and port-qualified entries;