PAC 2 - Add shared auth system proxy contract#26707
Merged
Merged
Conversation
6fcd2bd to
c1f900e
Compare
02c4962 to
9175bbb
Compare
4ffc2f4 to
968f40d
Compare
9b202fb to
ffb3961
Compare
bc1a433 to
691b9fa
Compare
celia-oai
reviewed
Jun 15, 2026
celia-oai
reviewed
Jun 15, 2026
008144e to
fa620b3
Compare
e74fc31 to
a2f4da6
Compare
a2f4da6 to
860d6e5
Compare
cooper-oai
reviewed
Jun 17, 2026
celia-oai
approved these changes
Jun 18, 2026
anp-oai
reviewed
Jun 18, 2026
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d2e9883c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
reviewed
Jun 19, 2026
This was referenced Jun 20, 2026
anp-oai
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #26706.
Adds the shared auth/system-proxy contract that later platform resolver PRs plug into. This PR moves Codex-owned auth and startup HTTP clients through a common route-aware boundary, but does not yet add Windows or macOS system proxy resolution.
The default path remains unchanged when
respect_system_proxyis absent or disabled.Implementation
codex-client/src/outbound_proxy.rswith the shared route-selection model:OutboundProxyConfig;ClientRouteClass;RouteFailureClass;build_reqwest_client_for_route.login::AuthRouteConfigso auth call sites depend on a small policy type instead of platform resolver details.Config.respect_system_proxyboolean intoAuthRouteConfigfor auth-owned clients.End-user behavior
respect_system_proxy = true, auth-owned clients opt into the shared route-aware client path.Tests
Adds or updates coverage for:
auth_route_config: Noneto guard unchanged default behavior;