fix: fixing cert command#627
Merged
shizhMSFT merged 5 commits intonotaryproject:mainfrom Apr 17, 2023
Merged
Conversation
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
patrickzheng200
requested review from
JeyJeyGao,
NiazFK,
SteveLasker,
gokarnm,
justincormack,
priteshbandi,
rgnote and
shizhMSFT
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #627 +/- ##
==========================================
+ Coverage 33.63% 33.95% +0.31%
==========================================
Files 32 32
Lines 1888 1882 -6
==========================================
+ Hits 635 639 +4
+ Misses 1232 1221 -11
- Partials 21 22 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added 2 commits
April 17, 2023 11:14
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
This PR aims to resolve notaryproject#622. It also adds MarkFlagRequired() to required flags in notation cert command. --------- Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
This PR aims to resolve notaryproject#622. It also adds MarkFlagRequired() to required flags in notation cert command. --------- Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #622.
It also adds MarkFlagRequired() to required flags in notation cert command.