chore: fixed notation cert command required flags; renamed notation key delete to notation key remove#608
Closed
patrickzheng200 wants to merge 5 commits intonotaryproject:mainfrom
Closed
chore: fixed notation cert command required flags; renamed notation key delete to notation key remove#608patrickzheng200 wants to merge 5 commits intonotaryproject:mainfrom
notation key delete to notation key remove#608patrickzheng200 wants to merge 5 commits intonotaryproject:mainfrom
Conversation
added 4 commits
March 30, 2023 14:29
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
patrickzheng200
requested review from
JeyJeyGao,
NiazFK,
SteveLasker,
gokarnm,
justincormack,
priteshbandi,
rgnote and
shizhMSFT
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #608 +/- ##
==========================================
+ Coverage 34.43% 34.78% +0.34%
==========================================
Files 32 32
Lines 1844 1843 -1
==========================================
+ Hits 635 641 +6
+ Misses 1188 1181 -7
Partials 21 21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
Closing this PR as the fix for notation cert command is moved into #627 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
MarkFlagRequired()to required flags innotation certcommand.notation key deletetonotation key remove; improved error message.