Skip to content

update: changed Sign to use OCI image manifest as default#573

Merged
patrickzheng200 merged 2 commits intonotaryproject:mainfrom
patrickzheng200:oci
Mar 2, 2023
Merged

update: changed Sign to use OCI image manifest as default#573
patrickzheng200 merged 2 commits intonotaryproject:mainfrom
patrickzheng200:oci

Conversation

@patrickzheng200
Copy link
Copy Markdown
Contributor

@patrickzheng200 patrickzheng200 commented Feb 28, 2023

This PR resolves #574 .

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #573 (b9cb105) into main (e47cf12) will not change coverage.
The diff coverage is 71.42%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #573   +/-   ##
=======================================
  Coverage   34.36%   34.36%           
=======================================
  Files          32       32           
  Lines        1848     1848           
=======================================
  Hits          635      635           
  Misses       1192     1192           
  Partials       21       21           
Impacted Files Coverage Δ
cmd/notation/sign.go 40.18% <66.66%> (ø)
cmd/notation/registry.go 16.19% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@patrickzheng200 patrickzheng200 changed the title update: changed default Sign to OCI image manifest update: changed Sign to use OCI image manifest as default Feb 28, 2023
@patrickzheng200 patrickzheng200 self-assigned this Feb 28, 2023
@patrickzheng200 patrickzheng200 added enhancement New feature or request cli Issue or PR released to Notation CLI labels Feb 28, 2023
@patrickzheng200 patrickzheng200 added this to the RC-3 milestone Feb 28, 2023
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickzheng200 patrickzheng200 merged commit b20f811 into notaryproject:main Mar 2, 2023
@patrickzheng200 patrickzheng200 deleted the oci branch March 2, 2023 10:00
duffney pushed a commit to duffney/notation that referenced this pull request Mar 30, 2023
…ect#573)

Signed-off-by: Josh Duffney <jduffney@microsoft.com>
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Issue or PR released to Notation CLI enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the default signature manifest

6 participants