Skip to content

fix: a quick fix on error message#567

Closed
patrickzheng200 wants to merge 3 commits intonotaryproject:mainfrom
patrickzheng200:fix
Closed

fix: a quick fix on error message#567
patrickzheng200 wants to merge 3 commits intonotaryproject:mainfrom
patrickzheng200:fix

Conversation

@patrickzheng200
Copy link
Copy Markdown
Contributor

No description provided.

Patrick Zheng added 2 commits February 24, 2023 13:39
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #567 (0f13236) into main (e47cf12) will not change coverage.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   34.36%   34.36%           
=======================================
  Files          32       32           
  Lines        1848     1848           
=======================================
  Hits          635      635           
  Misses       1192     1192           
  Partials       21       21           
Impacted Files Coverage Δ
cmd/notation/sign.go 40.18% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shizhMSFT
shizhMSFT previously approved these changes Feb 24, 2023
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao previously approved these changes Feb 27, 2023
Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickzheng200
Copy link
Copy Markdown
Contributor Author

Closing this PR as the error message is outdated again due to PR 573.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants