crypto: protect against string collisions#60392
Draft
ChALkeR wants to merge 2 commits intonodejs:mainfrom
Draft
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
panva
added
crypto
ChALkeR
commented
Oct 24, 2025
| validateStringWellFormed(val); | ||
| if (encoding === 'buffer') | ||
| encoding = 'utf8'; | ||
| return Buffer.from(val, encoding); |
Member
Author
There was a problem hiding this comment.
This could also cause collisions on well-formed strings but encodings not capable of containing full Unicode
That should be addressed too
ChALkeR
commented
Oct 24, 2025
| validateStringWellFormed(buffer); | ||
| if (encoding === 'buffer') | ||
| encoding = 'utf8'; | ||
| return Buffer.from(buffer, encoding); |
Member
Author
There was a problem hiding this comment.
This could also cause collisions on well-formed strings but encodings not capable of containing full Unicode
That should be addressed too
ChALkeR
commented
Oct 24, 2025
| Sign.prototype.update = function update(data, encoding) { | ||
| if (typeof data === 'string') { | ||
| validateEncoding(data, encoding); | ||
| validateStringWellFormed(data); |
Member
Author
There was a problem hiding this comment.
see other comments about encoding, this might also need adjustments and/or a check on src/ side
ChALkeR
commented
Oct 24, 2025
|
|
||
| if (typeof data === 'string') { | ||
| validateEncoding(data, encoding); | ||
| validateStringWellFormed(data); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes #60384
Closes: #60267
This is a draft.
Feedback is welcome though