test: test against hash/sign/verify collisions on strings#60384
Open
ChALkeR wants to merge 1 commit intonodejs:mainfrom
Open
test: test against hash/sign/verify collisions on strings#60384ChALkeR wants to merge 1 commit intonodejs:mainfrom
ChALkeR wants to merge 1 commit intonodejs:mainfrom
Conversation
730bc66 to
cae6903
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60384 +/- ##
==========================================
- Coverage 88.59% 88.58% -0.01%
==========================================
Files 704 704
Lines 207774 207774
Branches 40035 40030 -5
==========================================
- Hits 184068 184058 -10
- Misses 15748 15753 +5
- Partials 7958 7963 +5 🚀 New features to boost your workflow:
|
7f9d7ac to
1a73a6c
Compare
1a73a6c to
47db204
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #60267
Equal hashes should mean equal input
Passing
verify()should mean equal input to what was signedWarning
This PR does not fix the issue, but provides a testcase against it
Fixing would require checking all string input against
String.prototype.isWellFormed()or it's C++ alternativeIt would be (at least technically) a semver-major change
I'm not yet sure if callback-style methods should produce a synchronous error or pass it to the callback