build: fix VTune builds#60140
Closed
RReverser wants to merge 1 commit intonodejs:mainfrom
RReverser:fix-vtune
Closed
build: fix VTune builds#60140RReverser wants to merge 1 commit intonodejs:mainfrom RReverser:fix-vtune
RReverser wants to merge 1 commit intonodejs:mainfrom
RReverser:fix-vtune
Conversation
Collaborator
|
Review requested:
|
When trying to build with VTune support, I ran into couple of errors due to outdated paths in build configs.
Member
|
#59999 also attempts to fix the VTune builds. |
Member
Author
Ah didn't see that one. The only difference seems to be that you changed I'm happy with either one to land. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60140 +/- ##
==========================================
- Coverage 88.53% 88.52% -0.02%
==========================================
Files 703 703
Lines 207804 207804
Branches 40005 40010 +5
==========================================
- Hits 183989 183953 -36
- Misses 15817 15863 +46
+ Partials 7998 7988 -10
🚀 New features to boost your workflow:
|
Member
Author
|
Closing since #59999 was merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to build with VTune support, I ran into couple of errors due to outdated paths in build configs.