Skip to content

Update VTune include paths#59999

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
rahulchaphalkar:vtune-fix
Oct 7, 2025
Merged

Update VTune include paths#59999
nodejs-github-bot merged 1 commit intonodejs:mainfrom
rahulchaphalkar:vtune-fix

Conversation

@rahulchaphalkar
Copy link
Contributor

@rahulchaphalkar rahulchaphalkar commented Sep 24, 2025

Updates VTune include header paths which were changed in v8 v8/v8@846f470

This fixes the VTune build when built as follows

./configure --enable-vtune-profiling
make

and shows the appropriate JIT / Dynamic Code module in VTune.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 24, 2025

Review requested:

  • @nodejs/gyp
  • @nodejs/startup
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 24, 2025
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 24, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69360/

@codecov
Copy link

codecov bot commented Sep 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.48%. Comparing base (d2ff9da) to head (5b2efec).
⚠️ Report is 113 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59999      +/-   ##
==========================================
+ Coverage   88.45%   88.48%   +0.02%     
==========================================
  Files         703      703              
  Lines      207545   207529      -16     
  Branches    40013    40012       -1     
==========================================
+ Hits       183578   183625      +47     
+ Misses      15957    15885      -72     
- Partials     8010     8019       +9
Files with missing lines Coverage Δ
src/api/environment.cc 77.46% <ø> (+0.34%) ⬆️
src/node.cc 75.80% <ø> (ø)

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

addaleax
addaleax approved these changes Sep 25, 2025
View reviewed changes
@addaleax addaleax added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69376/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69467/

@rahulchaphalkar
Copy link
Contributor Author

rahulchaphalkar commented Oct 6, 2025

I looked into the failures, and they seem to be due to dyld[15564]: failed to set up thread local variables for '/Users/admin/node-tmp/.tmp.4766/sea': unsupported thread-local, larger than 4GB on OSX. I am not sure where to debug this, I don't have a mac machine, but want to know if this is a real failure or flaky tests?

@richardlau richardlau mentioned this pull request Oct 7, 2025
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 7, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69590/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit b13f24c into nodejs:main Oct 7, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 7, 2025

Landed in b13f24c

@RafaelGSS RafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
aduh95 pushed a commit that referenced this pull request Oct 31, 2025
@rahulchaphalkar @aduh95
build, src: fix include paths for vtune files
1be854f 
PR-URL: #59999
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actions github-actions bot mentioned this pull request Nov 7, 2025
Closed
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
@rahulchaphalkar @aduh95
build, src: fix include paths for vtune files
2505568 
PR-URL: #59999
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actions github-actions bot mentioned this pull request Nov 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rahulchaphalkar @nodejs-github-bot @addaleax @lpinca @joyeecheung @richardlau