v5.9.1 Release Proposal

[evanlucas]

v5.9.1 Release Proposal

Notable changes:

• contextify: Fix vm regression introduced in v5.9.0 (Ali Ijaz
  Sheikh) Backport 5786 to v5.x #5800

Commits:

• [c5d83695e1] - contextify: tie lifetimes of context & sandbox (Ali Ijaz Sheikh) #5800

[MylesBorins]

@evanlucas do you think we should include any other stages commits in this release?

/cc @Fishrock123

[evanlucas]

Since the past two releases have meant to fix regressions while introducing new ones, I think I would prefer to keep it as is. Open to yall's thoughts though

[cjihrig]

Since we waited until after the weekend to patch this, maybe we should do a "normal" release. Otherwise, we'll have a ton of commits next week, or another release in a day or two.

[Fishrock123]

Let's do a normal release. If you want to exclude semver-minor that is fine.

[evanlucas]

Ok, can anyone else pick this one up? Got a pretty busy week.

[rvagg]

I reckon we should probably avoid single-commit releases on Stable if possible, we're more likely to get regressions on Stable and that's part of the point of pushing it out in front of LTS (and makes a little bit of a mockery of the word "Stable" but oh well). The last 3 or 4 releases have had minor regressions in them but we still had a stable roll-out. I also don't believe the vm regression is going to impact a huge number of users, so unless we do something like completely break all fs operations then let's try and not get too worked up about regressions and just push forward and fix them calmly release in an orderly fashion. LTS exists for folks who want a much greater level of stability and assurance than we can provide on Stable.

[evanlucas]

@rvagg Fair enough :]

[Fishrock123]

@evanlucas I'll take it over.

[Fishrock123]

hmm, have to do a little more today than I expected, we'll see. XD

[Fishrock123]

Branch-diff commits list:

• [cde81b6b9f] - benchmark: fix linting errors (Rich Trott) #5840
• [d3c0d1bb8b] - buffer: throw range error before truncating write (Matt Loring) #5605
• [a53b2ac4b1] - contextify: tie lifetimes of context & sandbox (Ali Ijaz Sheikh) #5786
• [a76cb4d2f6] - deps: remove unused openssl files (Ben Noordhuis) #5619
• [8baaa25aec] - dns: use template literals (Benjamin Gruenbaum) #5809
• [b9299884dc] - dns: use isIp consistently (Benjamin Gruenbaum) #5804
• [e136c179c1] - doc: update crypto docs to use good defaults (Bill Automata) #5505
• [bac6c85056] - doc: add CTC meeting minutes 2016-02-10 (Rod Vagg) #5273
• [5aebbaeb49] - doc: add CTC meeting minutes 2016-02-03 (Rod Vagg) #5272
• [f70c71f168] - doc: explain error message on missing main file (Wolfgang Steiner) #5812
• [91cf55ba8e] - doc: add a cli options doc page (Jeremiah Senkpiel) #5787
• [54e6a8d6d7] - doc: Add windows example for Path.format (Mithun Patel) #5700
• [0fd3327879] - doc: grammar, clarity and links in timers doc (Bryan English) #5792
• [4f6ad5c1dd] - doc: align doc/api/tls.markdown with style guide (Stefano Vozza) #5706
• [5f1eb434ee] - doc: topic blocking vs non-blocking (Jarrett Widman) #5326
• [ac6af73a6d] - doc: fix typo in synchronous randomBytes example (Andrea Giammarchi) #5781
• [af09a9cc1b] - doc: fix crypto update() signatures (Brian White) #5500
• [929b5b92a5] - doc: fix multiline return comments in querystring (Claudio Rodriguez) #5705
• [9eb0ef4c2c] - doc: fix invalid path doc comments (Rich Trott) #5670
• [a97dfa0027] - doc: explain path.format() algorithm (Rich Trott) #5688
• [939d6efe0f] - doc: fix return value of write methods (Felix Böhm) #5736
• [f9e6191f85] - doc: reformat & improve node.1 manual page (Jeremiah Senkpiel) #5497
• [e6bdb6176b] - docs: fix man pages link if tok type is code (Mithun Patel) #5721
• [2e1ae3ead1] - https: fix ssl socket leak when keepalive is used (Alexander Penev) #5713
• [4d78121b77] - lib: simplify code with String.prototype.repeat() (Jackson Tian) #5359
• [d2b93e55cc] - lib: reduce usage of self = this (Jackson Tian) #5231
• [e6bfe044ff] - net: remove unused var self = this from old code (Benjamin Gruenbaum) #5224
• [9de9a08587] - path: refactor path.format() repeated code (Rich Trott) #5673
• [f158a8662d] - src,tools: use template literals (Rich Trott) #5778
• [c979a2d447] - test: smaller chunk size for smaller person.jpg (Jérémy Lal) #5813
• [2b60481942] - test: strip non-free icc profile from person.jpg (Jérémy Lal) #5813
• [6a3d38f00f] - test: remove timer from test-http-1.0 (Santiago Gimeno) #5129
• [c7b127025a] - test: repl tab completion test (Santiago Gimeno) #5534
• [287bdabe40] - test: make test-net-connect-options-ipv6.js better (Michael Dawson) #5791
• [8d394810e8] - test: fix test-cluster-worker-kill (Santiago Gimeno) #5814
• [74a703df84] - test: fix flaky test-cluster-shared-leak (Claudio Rodriguez) #5802
• [ccb7b45ba0] - test: minimize test-http-get-pipeline-problem (Rich Trott) #5728
• [0eb3ed50ba] - test: reduce brittleness of tab complete test (Matt Loring) #5772
• [d3a75344f5] - timers: fix lint from 4fe02e2 (Jeremiah Senkpiel) #5825
• [4fe02e23af] - timers: give Timeouts a constructor name (Jeremiah Senkpiel) #5793
• [089bef0a81] - timers: improve setImmediate() performance (Brian White) #4169
• [c67937bebb] - tools: remove unused imports (Sakthipriyan Vairamani) #5765

[Fishrock123]

I had to do like 9 conflict resolutions for this, so I want to run tests before I land any commits in v5.x.

CI: https://ci.nodejs.org/job/node-test-pull-request/2028/

citgm: https://ci.nodejs.org/job/thealphanerd-smoker/122/

[Fishrock123]

Notable changes

• buffer: Now properly throws RangeErrors on out-of-bounds writes (Matt Loring) #5605.
  • This effects write{Float|Double} when the noAssert option is not used.
• timers:
  • Returned timeout objects now have a Timeout constructor name (Jeremiah Senkpiel) #5793.
  • Performance of Immediate processing is now ~20-40% faster (Brian White) #4169.
• vm: Fixed a contextify regression introduced in v5.9.0 (Ali Ijaz Sheikh) #5800.

[Fishrock123]

Building at https://ci-release.nodejs.org/job/iojs+release/479/

[Fishrock123]

Ok screwed something up commits-wise, need to rebuild I guess.

CI to make sure everything is alright: https://ci.nodejs.org/job/node-test-pull-request/2032/

I'll do the actual promotion of (new) builds and blog tomorrow..

Edit: new builds: https://ci-release.nodejs.org/job/iojs+release/480/

[Fishrock123]

Ok I'm not sure what happened with my branches, but anyways I'm updating the date and running the CI jobs again.

CI: https://ci.nodejs.org/job/node-test-pull-request/2043/
Release builds: https://ci-release.nodejs.org/job/iojs+release/