Skip to content

path: refactor path.format() repeated code#5673

Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:dry-format
Closed

path: refactor path.format() repeated code#5673
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:dry-format

Conversation

@Trott
Copy link
Member

@Trott Trott commented Mar 12, 2016

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

path

Description of change

Refactor repeated code into a separate function.

@Trott Trott added path Issues and PRs related to the path subsystem. lts-watch-v4.x labels Mar 12, 2016
mscdex
mscdex reviewed Mar 12, 2016
View reviewed changes
lib/path.js Outdated
Copy link
Contributor

@mscdex mscdex Mar 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the function name will be lost in stack traces with the arrow function?

Copy link
Member Author

@Trott Trott Mar 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, then...will go back to the declaration style used in the rest of the object...

...and done!

@Trott
Copy link
Member Author

Trott commented Mar 12, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1907/

mscdex
mscdex reviewed Mar 12, 2016
View reviewed changes
lib/path.js Outdated
Copy link
Contributor

@mscdex mscdex Mar 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing function name here also

Copy link
Member Author

@Trott Trott Mar 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Fixed.

@Trott
Copy link
Member Author

Trott commented Mar 12, 2016

Minor fixup pushed. New CI: https://ci.nodejs.org/job/node-test-pull-request/1908/

@benjamingr
Copy link
Member

benjamingr commented Mar 12, 2016

LGTM, nice.

@benjamingr
Copy link
Member

benjamingr commented Mar 12, 2016

nit: wouldn't it make more sense to use win32.sep and posix.sep everywhere instead of the literals? Not that it should block the PR, just wondering since you've refactored out of that pattern.

Slayer95
Slayer95 reviewed Mar 12, 2016
View reviewed changes
lib/path.js Outdated
Copy link
Contributor

@Slayer95 Slayer95 Mar 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep the throws directly in path.format for better stack traces?
That would also avoid polymorphism in _format

Copy link
Member

@jasnell jasnell Mar 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 ... moving the throw up would be best.

Copy link
Member Author

@Trott Trott Mar 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good points about the stack trace and polymorphism as well. Rebased against master, changed according to these comments, and force pushed.

@jasnell
Copy link
Member

jasnell commented Mar 12, 2016

LGTM with a couple nits

@Trott Trott force-pushed the dry-format branch 2 times, most recently from 8627d44 to bc36ea2 Compare March 13, 2016 18:18
@Trott
Copy link
Member Author

Trott commented Mar 13, 2016

nit: wouldn't it make more sense to use win32.sep and posix.sep everywhere instead of the literals?

I had the same thought but went with the string literals because posix and win32 are defined using object literals. So they can't use posix.sep/win32.sep inside a function defined in the object literal. It could pass this.sep but that would be the only use of this in the entire file while the string literals are in multiple places. So I stuck with the string literals.

@Trott
Copy link
Member Author

Trott commented Mar 16, 2016

CI again: https://ci.nodejs.org/job/node-test-pull-request/1939/

@mscdex
Copy link
Contributor

mscdex commented Mar 16, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Mar 16, 2016
@Trott
path: refactor path.format() repeated code
9de9a08 
PR-URL: nodejs#5673
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@Trott
Copy link
Member Author

Trott commented Mar 16, 2016

Landed in 9de9a08

@Trott Trott closed this Mar 16, 2016
@Fishrock123 Fishrock123 mentioned this pull request Mar 22, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Mar 22, 2016
@Trott @Fishrock123
path: refactor path.format() repeated code
6e5835b 
PR-URL: #5673
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

Conflicts:
	lib/path.js
@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 30, 2016

This is blocked by other path changes /cc @nodejs/lts

@MylesBorins MylesBorins mentioned this pull request Apr 4, 2016
Closed
@Trott Trott deleted the dry-format branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

path Issues and PRs related to the path subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott @benjamingr @jasnell @mscdex @MylesBorins @Slayer95