win,msi: Added Italian translation by mcollina · Pull Request #4647 · nodejs/node

mcollina · 2016-01-12T12:24:07Z

I have added the Italian translation for the windows installer.
Is there something else to add?

Also, I do not have a dev env to build this bundle, so I did not test it.

cc @nodejs/platform-windows @nodejs/nodejs-it @piccoloaiutante

orangemocha · 2016-01-12T13:04:47Z

tools/msvs/msi/i18n/it-it.wxl

installto => installato

piccoloaiutante · 2016-01-12T13:23:33Z

@mcollina i could try to build it in the next two three days. What's the deadline for this task?

mcollina · 2016-01-18T08:52:41Z

Thanks @piccoloaiutante @orangemocha for reviewing, all your changes are in.

@piccoloaiutante it would be great if you could attempt a build, but I'll leave that decision to the @nodejs/platform-windows team on how to test this (I have no idea, but I would love to see this happening).

piccoloaiutante · 2016-01-18T12:43:00Z

@mcollina ok i'm downloading VS2013 to build six project because i'm currently unable to build it with my vs2015.
I hope to get it build by tomorrow :-)

joaocgreis · 2016-01-20T11:56:37Z

@mcollina this also needs to be added commented in nodemsi.wixproj, similar to https://github.com/nodejs/node/pull/2569/files .

@piccoloaiutante note that to build with VS2015 you need WiX 3.10. If you find issues with it, please report.

piccoloaiutante · 2016-01-20T13:37:39Z

@joaocgreis i had issue with my vs2015 professional update 1 on Windows 10. After having installed WiX 3.10.2.2516 i cannot build node WiX project because it seems that wcautil.h referenced in custom_action.cc is missing.

Do you have any suggestion? Should i rollback to vs2013?

mcollina · 2016-01-20T14:22:16Z

@joaocgreis I've added the nodemsi.wixproj stuff.

felixfbecker · 2016-01-24T15:11:08Z

@piccoloaiutante I have the same issue, anyone has a fix?

piccoloaiutante · 2016-01-25T08:08:51Z

@felixfbecker yes i solved it downloading WiX binaries and sources and adding their path to the custom_actions cpp project 'VC++ Directories' tab:

I still have problem during compilation time specifically for it-IT language. That's the output:

mcollina · 2016-01-25T08:19:08Z

Possibly it's my bad, any idea how to fix those?

piccoloaiutante · 2016-01-25T08:39:15Z

i fixed that problem @mcollina but then it seems i found some limit in WiX installer.

and this seems related to WiX libraries, as reported here:
http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/localized-variable-unknown-for-fr-FR-it-IT-and-some-other-cultures-td7585859.html

mcollina · 2016-03-02T08:54:30Z

@piccoloaiutante maybe you can send those translation to upstream at wix (see #2569 (comment))?

MylesBorins · 2016-06-17T22:25:08Z

@mcollina where are we at on this?

mcollina · 2016-06-20T06:19:56Z

I think it's blocked on Wix. Is the best course of action to submit a PR to add Italian to https://github.com/wixtoolset/wix3/tree/develop/src/ext/UtilExtension/wixlib?

piccoloaiutante · 2016-06-20T06:47:04Z

Sorry i missed it. Let me send the PR to WiX and see if it gets accepted.

piccoloaiutante · 2016-06-20T15:40:48Z

PR for italian translation for Wix has been submitted. I hope they'll evaluate it soon..

wixtoolset/wix3#366

piccoloaiutante · 2016-06-21T07:15:50Z

PR has been merged. I hope it gets its way into WiX weekly release so I can use it for building italian nodejs installer next week.

piccoloaiutante · 2016-06-29T09:30:43Z

Bad news, it seems that the code merged won't be released till next version of visual studio is released.

I hope they will make a weekly release as they have done in June.

wixtoolset/wix3#366

In the meantime i suggest to go on and send PR for the language that we need so we can have them in the next version of Wix.

One temporary solution that i could try is to build my own version of wix, but that seems pretty challenging..

piccoloaiutante · 2016-07-13T10:06:31Z

I finally got it working :)

mcollina · 2016-07-13T13:44:11Z

@fhemberger I think it's enabled: https://github.com/mcollina/node/blob/148f23c10f5f7c97030d27256c7a7a5510749716/tools/msvs/msi/nodemsi.wixproj#L59.

fhemberger · 2016-07-13T13:51:01Z

@mcollina No, the actual msi creation process is still disabled:
https://github.com/mcollina/node/blob/148f23c10f5f7c97030d27256c7a7a5510749716/tools/msvs/msi/nodemsi.wixproj#L79

@piccoloaiutante

As titled. Tested by @piccoloaiutante. PR-URL: nodejs#4647 Refs: wixtoolset/wix3#366 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>

mcollina · 2016-07-13T14:12:16Z

Merged in as c01d61a

fhemberger · 2016-07-13T15:16:29Z

@mcollina Great, thanks! Can we land #2569 as well?

mcollina · 2016-07-13T15:19:42Z

@fhemberger can't really tell. I think so, but I know nothing about Chinese :(.

fhemberger · 2016-07-13T15:24:31Z

@mcollina Well, regarding the content, there are several LGTMs from nodejs-cn.

@piccoloaiutante

As titled. Tested by @piccoloaiutante. PR-URL: #4647 Refs: wixtoolset/wix3#366 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>

Notable changes: * deps: upgrade to V8 5.0.71.54 (Ben Noordhuis) [#7531](#7531) * win,msi * add zh-CN translations for the installer (Minqi Pan) [#2569](#2569) * Added Italian translation (Matteo Collina) [#4647](#4647) PR-URL: #7782

@piccoloaiutante

As titled. Tested by @piccoloaiutante. PR-URL: #4647 Refs: wixtoolset/wix3#366 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>

MylesBorins · 2016-09-30T16:12:03Z

@mcollina I am landing this on v4.x-staging. Would you be able to build and test that things are not weird?

@piccoloaiutante

As titled. Tested by @piccoloaiutante. PR-URL: #4647 Refs: wixtoolset/wix3#366 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>

mcollina · 2016-09-30T16:19:48Z

@thealphanerd not really, @piccoloaiutante will do it :)

mcollina · 2016-09-30T16:21:13Z

@thealphanerd as far as I remember, the translated installers were not enabled. Are you enabling them in the next release?

MylesBorins · 2016-09-30T16:39:41Z

@mcollina I was unaware of that... just working on general backporting 💃

does this need to be enabled in our release process? Want to make an issue on build?

mcollina · 2016-09-30T16:54:09Z

@thealphanerd I'm not really 100% of what that takes @piccoloaiutante did most of the windows-specific stuff. He is also looking to help on build nodejs/build#495.
I will let him drive this.

piccoloaiutante · 2016-10-03T12:32:59Z

@thealphanerd enabling build for it-IT in in nodemsi.wixproj i was able to build this PR out of v4.x-staging. Do you need anything else?

piccoloaiutante · 2016-10-03T12:45:49Z

@thealphanerd don't forget that in order to build it you need to install the weekly build of wixtoolset http://wixtoolset.org/releases/v3-11-0-906/ where my PR for WiX has been included.

MylesBorins · 2016-10-03T14:54:52Z

thanks for the confirmation, that was all I needed

On Mon, Oct 3, 2016, 8:45 AM Michele Capra notifications@github.com wrote:

@thealphanerd https://github.com/TheAlphaNerd don't forget that in
order to build it you need to install the weekly build of wixtoolset
http://wixtoolset.org/releases/v3-11-0-906/ where my PR for WiX has been
included.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4647 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecVwGPq_0veNa_IWjD-OrRXqBWBi7Eks5qwPkEgaJpZM4HDGdc
.

@piccoloaiutante

As titled. Tested by @piccoloaiutante. PR-URL: #4647 Refs: wixtoolset/wix3#366 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>

@piccoloaiutante

As titled. Tested by @piccoloaiutante. PR-URL: #4647 Refs: wixtoolset/wix3#366 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>

orangemocha reviewed Jan 12, 2016
View reviewed changes

tools/msvs/msi/i18n/it-it.wxl Outdated

Copy link

Contributor

orangemocha Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installto => installato

mscdex added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. labels Jan 12, 2016

mcollina force-pushed the msvs-it branch from 0d7129e to dc19ac3 Compare January 18, 2016 08:51

mcollina force-pushed the msvs-it branch from dc19ac3 to ea5a0d4 Compare January 20, 2016 14:21

joaocgreis mentioned this pull request Mar 1, 2016

Add zh-CN i18n support for Windows installer #2569

Closed

estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:22

mcollina closed this Jul 13, 2016

evanlucas pushed a commit that referenced this pull request Jul 15, 2016

win,msi: Added Italian translation

f25c7ce

As titled. Tested by @piccoloaiutante. PR-URL: #4647 Refs: wixtoolset/wix3#366 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>

evanlucas mentioned this pull request Jul 18, 2016

v6.3.1 Release Proposal #7782

Merged

joaocgreis mentioned this pull request Jul 19, 2016

win,msi: fix inclusion of translations #7798

Closed

2 tasks

cjihrig mentioned this pull request Aug 8, 2016

v6.4.0 Release Proposal #8020

Closed

cjihrig pushed a commit that referenced this pull request Aug 10, 2016

win,msi: Added Italian translation

dbbcb9d

As titled. Tested by @piccoloaiutante. PR-URL: #4647 Refs: wixtoolset/wix3#366 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>

cjihrig mentioned this pull request Aug 11, 2016

v6.4.0 Proposal #8070

Merged

MylesBorins added the land-on-v4.x label Sep 30, 2016

mcollina deleted the msvs-it branch September 30, 2016 16:19

rvagg pushed a commit that referenced this pull request Oct 18, 2016

win,msi: Added Italian translation

e70146a

As titled. Tested by @piccoloaiutante. PR-URL: #4647 Refs: wixtoolset/wix3#366 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>

MylesBorins mentioned this pull request Oct 26, 2016

V4.6.2 proposal #9298

Closed

Uh oh!

Conversation

mcollina commented Jan 12, 2016

Uh oh!

orangemocha Jan 12, 2016

Choose a reason for hiding this comment

Uh oh!

piccoloaiutante commented Jan 12, 2016

Uh oh!

mcollina commented Jan 18, 2016

Uh oh!

piccoloaiutante commented Jan 18, 2016

Uh oh!

joaocgreis commented Jan 20, 2016

Uh oh!

piccoloaiutante commented Jan 20, 2016

Uh oh!

mcollina commented Jan 20, 2016

Uh oh!

felixfbecker commented Jan 24, 2016

Uh oh!

piccoloaiutante commented Jan 25, 2016

Uh oh!

mcollina commented Jan 25, 2016

Uh oh!

piccoloaiutante commented Jan 25, 2016

Uh oh!

mcollina commented Mar 2, 2016

Uh oh!

MylesBorins commented Jun 17, 2016

Uh oh!

mcollina commented Jun 20, 2016

Uh oh!

piccoloaiutante commented Jun 20, 2016

Uh oh!

piccoloaiutante commented Jun 20, 2016

Uh oh!

piccoloaiutante commented Jun 21, 2016

Uh oh!

piccoloaiutante commented Jun 29, 2016

Uh oh!

piccoloaiutante commented Jul 13, 2016

Uh oh!

mcollina commented Jul 13, 2016

Uh oh!

fhemberger commented Jul 13, 2016

Uh oh!

mcollina commented Jul 13, 2016

Uh oh!

fhemberger commented Jul 13, 2016

Uh oh!

mcollina commented Jul 13, 2016

Uh oh!

fhemberger commented Jul 13, 2016

Uh oh!

MylesBorins commented Sep 30, 2016

Uh oh!

mcollina commented Sep 30, 2016

Uh oh!

mcollina commented Sep 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MylesBorins commented Sep 30, 2016

Uh oh!

mcollina commented Sep 30, 2016

Uh oh!

piccoloaiutante commented Oct 3, 2016

Uh oh!

piccoloaiutante commented Oct 3, 2016

Uh oh!

MylesBorins commented Oct 3, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mcollina commented Sep 30, 2016 •

edited

Loading