Add zh-CN i18n support for Windows installer by pmq20 · Pull Request #2569 · nodejs/node

pmq20 · 2015-08-27T04:34:55Z

This is a follow-up on #2247 and #819

@JacksonTian Could you review the translations? thanks!

JacksonTian · 2015-08-27T07:43:07Z

tools/msvs/msi/i18n/zh-cn.wxl

已安装的xxx的去掉前一个的

pmq20 · 2015-08-27T07:48:29Z

Thank you @JacksonTian for reviewing. Typo fixed.

JacksonTian · 2015-08-27T07:50:27Z

tools/msvs/msi/i18n/zh-cn.wxl

Fishrock123 · 2015-08-28T13:22:49Z

cc @nodejs/iojs-cn

laosb · 2015-08-29T05:56:32Z

Seems good.

dead-horse · 2015-08-29T12:04:32Z

LGTM

Fishrock123 · 2015-08-29T13:30:20Z

@joaocgreis I think you are the most familiar with the windows installer bits, could you review that?

joaocgreis · 2015-08-29T14:08:51Z

LGTM

cc @fhemberger

yorkie · 2015-08-29T14:21:04Z

tools/msvs/msi/i18n/zh-cn.wxl

What's the correct/better translation about the often word "module"? "模块" vs. "模组", as for me, +1 on "模组" :)

Just Taiwan or Hongkong use "模组" for module.

Ok, I see...LGTM now

fengmk2 · 2015-08-29T17:25:58Z

👍

fhemberger · 2015-08-30T05:53:35Z

Wow, awesome! I was planning to write an issue for all translators about the Windows installer. You were faster. ;)

LGTM

fhemberger · 2015-12-18T05:22:03Z

@nodejs/collaborators Can someone please merge this? It has no direct influence on the build (translations are still commented out).

rvagg · 2015-12-18T05:24:02Z

I might run a test build of it to get feedback from native speakers, hold on

rvagg · 2015-12-18T05:37:48Z

ah, it's kind of old, @pmq20 would you mind rebasing this off master please?

pmq20 · 2015-12-19T04:25:23Z

@rvagg Sure. Rebased.

joaocgreis · 2016-01-20T11:52:09Z

@rvagg can I land this? If you still want to get some feedback, note that this is being committed commented in nodemsi.wixproj. Let me know what I can do to help you.

rvagg · 2016-01-20T12:06:32Z

go ahead @joaocgreis, I put out a call but am happy to trust @pmq20 on this, I'm sure we'll get feedback on anything that can be tweaked.

joaocgreis · 2016-03-01T20:37:16Z

This builds well with the translation commented, but fails otherwise with the same problem as #4647 (comment) . Upstream WiX has a translation for German, but none for Chinese or Italian. A possible workaround seems to be adding those variables to the translation file, translating the original. The best would be to submit it upstream. @fhemberger do you know of a better solution for this?

fhemberger · 2016-03-02T04:34:36Z

@joaocgreis Sounds good to me. Sorry, I'm no expert on this topic either. I dug into WiX once over a weekend for the initial German translation but never used it before.

joaocgreis · 2016-03-02T11:26:34Z

@mcollina that would be great! @pmq20 would you consider this for zh-CN?

piccoloaiutante · 2016-03-02T13:47:36Z

@mcollina yes we can, so we can finally have the italian version :-)

MylesBorins · 2016-06-17T21:28:16Z

@nodejs/build is there something keeping this from landing?

fhemberger · 2016-06-18T05:55:20Z

@thealphanerd This can be merged, as the translation is still commented, so nothing will break.
There is still this issue to be solved to get zh-CN up and running:
#2569 (comment)

So we still need a PR for the WiX toolset to add Chinese, Italian, et. al.

XadillaX · 2016-07-07T09:04:56Z

LGTM.

laosb · 2016-07-08T04:33:54Z

Can't believe that this is still not merged.

mcollina · 2016-07-13T15:32:44Z

@piccoloaiutante did the PR to WiX for Italian (wixtoolset/wix3#366). Did an equivalent PR happen for Chinese as well?

pmq20 · 2016-07-14T02:57:25Z

@joaocgreis @mcollina Sure. Thanks for the Italian example. Let me do the same thing for the Chinese language.

This PR is lasting too long to be merged. Let me first merge the translation (which has been thoroughly reviewed) and then create new PR's for the translations to take effect.

PR-URL: nodejs#2569 Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Wexpo Lyu <laosb@lns.unihubs.com> Reviewed-By: Yiyu He <heyiyu.deadhorse@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>

pmq20 · 2016-07-14T03:03:33Z

Landed in e09c62a

PR-URL: #2569 Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Wexpo Lyu <laosb@lns.unihubs.com> Reviewed-By: Yiyu He <heyiyu.deadhorse@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>

Notable changes: * deps: upgrade to V8 5.0.71.54 (Ben Noordhuis) [#7531](#7531) * win,msi * add zh-CN translations for the installer (Minqi Pan) [#2569](#2569) * Added Italian translation (Matteo Collina) [#4647](#4647) PR-URL: #7782

PR-URL: #2569 Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Wexpo Lyu <laosb@lns.unihubs.com> Reviewed-By: Yiyu He <heyiyu.deadhorse@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>

MylesBorins · 2016-09-30T16:14:04Z

@pmq20 I've added this to v4.x-staging. Would you be able to test and make sure it works as expected before we do another release

PR-URL: #2569 Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Wexpo Lyu <laosb@lns.unihubs.com> Reviewed-By: Yiyu He <heyiyu.deadhorse@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>

pmq20 force-pushed the psvr-zh-cn-1 branch from 7d4af9b to 0b5a888 Compare August 27, 2015 04:37

brendanashworth added windows Issues and PRs related to the Windows platform. i18n-api Issues and PRs related to the i18n implementation. install Issues and PRs related to the installers. labels Aug 27, 2015

JacksonTian reviewed Aug 27, 2015
View reviewed changes

tools/msvs/msi/i18n/zh-cn.wxl Outdated

Copy link

Contributor

JacksonTian Aug 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已安装的xxx的去掉前一个的

pmq20 force-pushed the psvr-zh-cn-1 branch from 0b5a888 to e3bd78a Compare August 27, 2015 07:48

JacksonTian reviewed Aug 27, 2015
View reviewed changes

tools/msvs/msi/i18n/zh-cn.wxl Outdated

Copy link

Contributor

JacksonTian Aug 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以及以

pmq20 force-pushed the psvr-zh-cn-1 branch from e3bd78a to 6f4e94d Compare August 27, 2015 07:55

yorkie reviewed Aug 29, 2015
View reviewed changes

rvagg force-pushed the master branch from 11c25c2 to ba02bd0 Compare September 6, 2015 11:55

pmq20 force-pushed the psvr-zh-cn-1 branch from 6f4e94d to c017381 Compare December 19, 2015 04:25

Trott force-pushed the master branch from 1e896a6 to 082cc8d Compare December 27, 2015 02:00

mcollina mentioned this pull request Mar 2, 2016

win,msi: Added Italian translation #4647

Closed

estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:22

win,msi: add zh-CN translations for the installer

1a3ecb0

pmq20 force-pushed the psvr-zh-cn-1 branch from c017381 to 1a3ecb0 Compare July 14, 2016 02:53

pmq20 closed this Jul 14, 2016

pmq20 deleted the psvr-zh-cn-1 branch July 14, 2016 03:04

evanlucas mentioned this pull request Jul 18, 2016

v6.3.1 Release Proposal #7782

Merged

joaocgreis mentioned this pull request Jul 19, 2016

win,msi: fix inclusion of translations #7798

Closed

2 tasks

cjihrig mentioned this pull request Aug 8, 2016

v6.4.0 Release Proposal #8020

Closed

evanlucas mentioned this pull request Aug 24, 2016

2016-08-26, Version 6.5.0 (Current) #8253

Merged

MylesBorins added the land-on-v4.x label Sep 30, 2016

MylesBorins mentioned this pull request Oct 26, 2016

V4.6.2 proposal #9298

Closed

Uh oh!

Conversation

pmq20 commented Aug 27, 2015

Uh oh!

JacksonTian Aug 27, 2015

Choose a reason for hiding this comment

Uh oh!

pmq20 commented Aug 27, 2015

Uh oh!

JacksonTian Aug 27, 2015

Choose a reason for hiding this comment

Uh oh!

Fishrock123 commented Aug 28, 2015

Uh oh!

laosb commented Aug 29, 2015

Uh oh!

dead-horse commented Aug 29, 2015

Uh oh!

Fishrock123 commented Aug 29, 2015

Uh oh!

joaocgreis commented Aug 29, 2015

Uh oh!

yorkie Aug 29, 2015

Choose a reason for hiding this comment

Uh oh!

JacksonTian Aug 29, 2015

Choose a reason for hiding this comment

Uh oh!

yorkie Aug 29, 2015

Choose a reason for hiding this comment

Uh oh!

fengmk2 commented Aug 29, 2015

Uh oh!

fhemberger commented Aug 30, 2015

Uh oh!

fhemberger commented Dec 18, 2015

Uh oh!

rvagg commented Dec 18, 2015

Uh oh!

rvagg commented Dec 18, 2015

Uh oh!

pmq20 commented Dec 19, 2015

Uh oh!

joaocgreis commented Jan 20, 2016

Uh oh!

rvagg commented Jan 20, 2016

Uh oh!

joaocgreis commented Mar 1, 2016

Uh oh!

fhemberger commented Mar 2, 2016

Uh oh!

joaocgreis commented Mar 2, 2016

Uh oh!

piccoloaiutante commented Mar 2, 2016

Uh oh!

MylesBorins commented Jun 17, 2016

Uh oh!

fhemberger commented Jun 18, 2016

Uh oh!

XadillaX commented Jul 7, 2016

Uh oh!

laosb commented Jul 8, 2016

Uh oh!

mcollina commented Jul 13, 2016

Uh oh!

pmq20 commented Jul 14, 2016

Uh oh!

pmq20 commented Jul 14, 2016

Uh oh!

MylesBorins commented Sep 30, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants