deps: upgrade to [email protected]

[guybedford]

This upgrades to [email protected] which filters CJS named exports detection to not detect getter properties like:

Object.defineProperty(exports, 'prop', {
  get () {
    throw new Error('error');
  }
});

The filtering is entirely handled by the lexer no longer emitting this case, while making an exception for __esModule.

Fixes #35859.

As a result, these cases which previously would be detected as named exports no longer come up as named exports, but it is a relatively minor edge case we expect.

Since the cases that this affects are relatively minor, and since this feature is still experimental we do not need to treat this as formally breaking and should instead aim to get this out asap to maximise compatibility.

Requesting to fast track this PR, please give a thumbs up or thumbs down here to help push it through.

@nodejs/modules-active-members

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

Review requested:

• @nodejs/modules

[MylesBorins]

We should fast track this to get it in the next 15 and into 14 / 12 asap

[panva]

Is #35857 (comment) related to this? Will these node stdlib module getters not be available as named exports in esm?

[guybedford]

@panva conceptually it's the same thing, but it's different code running. The ESM sync with core libs happens in https://github.com/nodejs/node/blob/master/lib/internal/bootstrap/loaders.js#L237. In your PR I'd suggest either making those properties non enumerable or you can add some extra code in there that skips properties via a marker / whether they use a getter / or even just disables warnings. There's a few ways to go but I'm sure you'll be able to solve it there.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/33943/

[mhdawson]

Rubber Stamp LGTM

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/33948/

[guybedford]

Landed in b92d2e4. Thanks all for the quick review here.

[aduh95]

I've added dont-land labels in case this is related to #35893, feel free to remove them if it's unrelated or if the issue is a wont-fix.