crypto: add experimental warning to crypto.webcrypto#35857
Closed
panva wants to merge 1 commit intonodejs:masterfrom
Closed
crypto: add experimental warning to crypto.webcrypto#35857panva wants to merge 1 commit intonodejs:masterfrom
panva wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
|
Review requested:
|
c46a50b to
7dd99de
Compare
mscdex
reviewed
Oct 28, 2020
75c71f4 to
b54d29f
Compare
lpinca
approved these changes
Oct 28, 2020
Member
Author
|
meh, i'm getting the experimental warning even by just requiring crypto, not when accessing --trace-warnings seems to be a sideproduct of ESM's syncExports? Not sure how to proceed from here. |
This adds a once-per-process ExperimentalWarning when Web Crypto API is accessed.
b54d29f to
34583ea
Compare
3 tasks
Member
Author
|
@guybedford I don't want to pollute the other PR we engaged in. So here I'd like to make the Any other ideas? |
Member
Author
|
Closing for clear lack of interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a once-per-process ExperimentalWarning when Web Crypto API is accessed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes