test: add test for expose_internals and expose-internals flag#32554
Closed
juanarbol wants to merge 1 commit intonodejs:masterfrom
Closed
test: add test for expose_internals and expose-internals flag#32554juanarbol wants to merge 1 commit intonodejs:masterfrom
juanarbol wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
approved these changes
Mar 29, 2020
Trott
approved these changes
Mar 30, 2020
Member
There was a problem hiding this comment.
I'd prefer a more informative commit message. As written, it seems to say that we're adding a test for the CLI flag, but this adds a test to make sure that flag is disallowed in NODE_OPTIONS.
test: check that --expose-internals is disallowed in NODE_OPTIONS
Add test cases that confirm that `--expose-internals` and
`--expose_internals` are disallowed in the NODE_OPTIONS environment
variable.
Add test cases that confirm that `--expose-internals` and `--expose_internals` are disallowed in the NODE_OPTIONS environment variable.
juanarbol
force-pushed
the
juanarbol/add-test-for-expose_internals-flag
branch
from
ac884c6 to
2383373
Compare
Member
Author
The commit message is changed now! Thanks for reviewing! |
addaleax
added
the
author ready
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Apr 3, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Member
|
Landed in 0826935 |
Trott
pushed a commit
that referenced
this pull request
Apr 6, 2020
Add test cases that confirm that `--expose-internals` and `--expose_internals` are disallowed in the NODE_OPTIONS environment variable. PR-URL: #32554 Refs: #32542 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Add test cases that confirm that `--expose-internals` and `--expose_internals` are disallowed in the NODE_OPTIONS environment variable. PR-URL: #32554 Refs: #32542 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Add test cases that confirm that `--expose-internals` and `--expose_internals` are disallowed in the NODE_OPTIONS environment variable. PR-URL: #32554 Refs: #32542 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Add test cases that confirm that `--expose-internals` and `--expose_internals` are disallowed in the NODE_OPTIONS environment variable. PR-URL: #32554 Refs: #32542 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #32542
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes