test: replace flag expose_internals to expose-internals

[juanarbol]

They are the same, but --expose-internals seems to be the standard, actually, the written on src/node_options.h file, and by the way, --expose_internals flag is not documented anywhere.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[cjihrig]

by the way, --expose_internals flag is not documented anywhere.

It sort of is: https://nodejs.org/api/cli.html#cli_options

[juanarbol]

It sort of is: https://nodejs.org/api/cli.html#cli_options

I'm blind 🤦‍♂️

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/30171/ (:yellow_heart:)

[sam-github]

No strong feelings on this PR, but note that using a mixture of _ and - in the tests, while it seems inconsistent, has a side-effect of ensuring that both continue to be supported (as documented).

[jasnell]

@sam-github ... if we're concerned about that, then there should be a separate dedicated test that ensures that both _ and - options work correctly.

[cjihrig]

There is test/parallel/test-cli-node-options.js.

EDIT: Specifically these lines:

node/test/parallel/test-cli-node-options.js

Lines 26 to 27 in cd1db2d

	expect('--no-warnings', 'B\n');
	expect('--no_warnings', 'B\n');

[juanarbol]

I think I can add a test for both flags.

[addaleax]

Landed in 7534477