[10.x] test: Mark test-http2-client-upload as flaky on 10.x#31887
Closed
AshCripps wants to merge 2 commits intonodejs:v10.x-stagingfrom
Closed
[10.x] test: Mark test-http2-client-upload as flaky on 10.x#31887AshCripps wants to merge 2 commits intonodejs:v10.x-stagingfrom
AshCripps wants to merge 2 commits intonodejs:v10.x-stagingfrom
Conversation
AshCripps
changed the title
BethGriggs
approved these changes
Feb 20, 2020
Collaborator
Collaborator
richardlau
approved these changes
Feb 20, 2020
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
Non-blocking nit: move the new entry to the top of the section so the listed tests are in alphabetical order.
AshCripps
force-pushed
the
make-10.x-http-tests-flaky
branch
from
978f705 to
c98d964
Compare
This test is already marked as flaky on 12.x and master
AshCripps
force-pushed
the
make-10.x-http-tests-flaky
branch
from
c98d964 to
3a54d73
Compare
Member
|
I've cherry-picked #27277 on to the staging branch, hopefully that'll help us get stable CI's. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
These tests are also flaky on v10.x
Collaborator
4 tasks
BethGriggs
pushed a commit
that referenced
this pull request
Feb 24, 2020
These tests are already marked as flaky on 12.x and master. PR-URL: #31887 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Member
|
Landed in a8fd8a1 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is failing ci a lot and is already marked as flaky on master and 12.x