test: try to stabilize test-child-process-fork-exec-path.js#27277
Closed
refack wants to merge 3 commits intonodejs:masterfrom
Closed
test: try to stabilize test-child-process-fork-exec-path.js#27277refack wants to merge 3 commits intonodejs:masterfrom
refack wants to merge 3 commits intonodejs:masterfrom
Conversation
Collaborator
Trott
reviewed
Apr 17, 2019
refack
force-pushed
the
stablize-test-child-process-fork-exec-path
branch
from
3dda26d to
5ec9d3f
Compare
refack
added
child_process
Contributor
Author
|
This reproduces differently using the stress job - https://ci.nodejs.org/job/node-stress-single-test/2204/ So I've started 3 Windows jobs Details
|
Contributor
Author
|
Still no boeno c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:27
throw e;
^
Error: ENOTEMPTY: directory not empty, rmdir 'c:\workspace\node-test-binary-windows-2\test\.tmp.3'
at Object.rmdirSync (fs.js:706:3)
at rmdirSync (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:48:10)
at rimrafSync (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:18:7)
at Object.refresh (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:66:3)
at process.<anonymous> (c:\workspace\node-test-binary-windows-2\test\parallel\test-child-process-fork-exec-path.js:66:12) |
refack
force-pushed
the
stablize-test-child-process-fork-exec-path
branch
from
5ec9d3f to
31bc7d0
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
Is there a good reason we're using tmpdir at all? Why not just use the node executable where it is and don't move/copy/remove anything at all? EDIT: I guess to make sure it's not ignoring the |
Contributor
Author
Worth documenting though |
refack
force-pushed
the
stablize-test-child-process-fork-exec-path
branch
from
9a01a9a to
6bdc8d7
Compare
refack
force-pushed
the
stablize-test-child-process-fork-exec-path
branch
from
6bdc8d7 to
907567e
Compare
Collaborator
Contributor
Author
Contributor
Author
|
@nodejs/testing This flake has been failing fairly often in the last few days. |
richardlau
reviewed
Apr 17, 2019
richardlau
approved these changes
Apr 18, 2019
joyeecheung
approved these changes
Apr 18, 2019
Contributor
|
Landed in 4f8b497. |
danbev
pushed a commit
that referenced
this pull request
Apr 18, 2019
PR-URL: #27277 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This was referenced Apr 23, 2019
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2020
PR-URL: #27277 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to de-flake
test/parallel/test-child-process-fork-exec-path.jsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes