Closed
Conversation
Merge two similar sentences into one.
nodejs-github-bot
added
doc
gireeshpunathil
approved these changes
Feb 20, 2020
cjihrig
approved these changes
Feb 20, 2020
ronag
approved these changes
Feb 25, 2020
jasnell
approved these changes
Feb 25, 2020
jasnell
approved these changes
Feb 25, 2020
Member
|
doc only so the green travis CI should be enough to land. |
mhdawson
pushed a commit
that referenced
this pull request
Feb 27, 2020
Merge two similar sentences into one. PR-URL: #31868 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
|
Landed in a777cfa |
Contributor
|
This doesn't land cleanly on v13.x. Can you please open a backport if it should be applied to that branch |
Member
Author
|
Depends on #31812 which in order depends on a semver-major change. It should not be backported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge two similar sentences into one.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes