doc: fix Writable.write callback description#31812
doc: fix Writable.write callback description#31812ronag wants to merge 3 commits intonodejs:masterfrom
Conversation
|
@nodejs/streams |
Clarifies a userland invariant until a better solution can be found. Also moves a misplaced sentence from _write to write. Refs: nodejs#31756 Refs: nodejs#31765
ronag
force-pushed
the
stream-doc-writable-callback
branch
from
0cf3ff7 to
8c19c23
Compare
|
I think this depends on #31317. |
How so? This is a timing issue related to when and how the |
Perhaps I'm misunderstanding this? Note "always". Or does that mean that if the callback is called it will be called asynchronously? |
Ah now I see what you mean. That part was incorrectly written at And yes the "always" is a bit ambigious but I think the intention is that "is called it will be called asynchronously". Maybe removing "always" would amke it clearer? |
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
ronag
added
the
author ready
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
Clarifies a userland invariant until a better solution can be found. Also moves a misplaced sentence from _write to write. Refs: #31756 Refs: #31765 PR-URL: #31812 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 7c524fb |
|
This does not land cleanly on v13.x. Could you please open a backport PR if it should land on that branch |
|
I think 75b30c6 must be backported first. Then this will land cleanly. |
|
75b30c6 is semver-major, so this should not be backported. |
6 participants
Clarifies a userland invariant until a better
solution can be found.
Also moves a misplaced sentence from _write to
write.
Refs: #31756
Refs: #31765
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes