Closed
Conversation
nodejs-github-bot
added
the
stream
Member
|
I think these files are used in https://github.com/nodejs/readable-stream and still support older versions of Node.js so the performance would need to be checked on those? cc @nodejs/streams |
mcollina
approved these changes
Dec 14, 2019
Member
|
Those do not sit in a hot path, as far as I know. |
trivikr
added
the
author ready
Collaborator
lpinca
approved these changes
Dec 14, 2019
addaleax
approved these changes
Dec 14, 2019
Trott
approved these changes
Dec 14, 2019
BridgeAR
approved these changes
Dec 15, 2019
targos
approved these changes
Dec 15, 2019
jasnell
approved these changes
Dec 15, 2019
jasnell
approved these changes
Dec 15, 2019
soar-beep
added a commit
to soar-beep/node
that referenced
this pull request
Dec 16, 2019
trivikr
added a commit
that referenced
this pull request
Dec 16, 2019
PR-URL: #30960 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in ce49f90 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30960 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 18, 2019
Refs: nodejs#30960 PR-URL: nodejs#30983 Refs: nodejs#30960 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #30960 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30960 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searched for regular expression
for \([^\.]*.lengthinliband made changes in_stream_*filesRefs: #30910 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes