lib: change var to let/const#30910
Closed
herrmannplatz wants to merge 1 commit intonodejs:masterfrom
herrmannplatz:sn-code-contribution
Closed
lib: change var to let/const#30910herrmannplatz wants to merge 1 commit intonodejs:masterfrom herrmannplatz:sn-code-contribution
herrmannplatz wants to merge 1 commit intonodejs:masterfrom
herrmannplatz:sn-code-contribution
Conversation
nodejs-github-bot
added
the
console
BridgeAR
approved these changes
Dec 12, 2019
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
Welcome to Node.js @herrmannplatz.
LGTM, just left a suggestion.
herrmannplatz
changed the title
targos
approved these changes
Dec 12, 2019
gireeshpunathil
approved these changes
Dec 12, 2019
gengjiawen
approved these changes
Dec 12, 2019
cjihrig
approved these changes
Dec 12, 2019
Trott
approved these changes
Dec 13, 2019
Collaborator
Collaborator
Collaborator
Trott
added
the
author ready
trivikr
approved these changes
Dec 14, 2019
This was referenced Dec 14, 2019
Closed
Closed
Closed
Closed
addaleax
pushed a commit
that referenced
this pull request
Dec 14, 2019
PR-URL: #30910 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
Landed in 952b90c |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30910 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This was referenced Dec 21, 2019
Closed
Closed
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #30910 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30910 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes