Skip to content

src: use uv_async_t for WeakRefs#30616

Closed
addaleax wants to merge 3 commits intonodejs:masterfrom
addaleax:finalization-tasks
Closed

src: use uv_async_t for WeakRefs#30616
addaleax wants to merge 3 commits intonodejs:masterfrom
addaleax:finalization-tasks

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Nov 23, 2019 •
edited
Loading

Schedule a task on the main event loop, similar to what the HTML
spec recommends for browsers.

Alternative to #30198

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
src: use uv_async_t for WeakRefs
3b8b241 
Schedule a task on the main event loop, similar to what the HTML
spec recommends for browsers.

Alternative to nodejs#30198
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 23, 2019
@addaleax addaleax requested a review from devsnek November 23, 2019 23:36
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 23, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26888/

bnoordhuis
bnoordhuis approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR itself LGTM but the test fails on the Windows bots. The ICE on the ARM buildbot appears to be an OOM.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 27, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27108/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 28, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27138/

@addaleax addaleax mentioned this pull request Nov 28, 2019
Open
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2019
@addaleax
Copy link
Member Author

addaleax commented Nov 29, 2019

Landed in fad952a

@addaleax addaleax closed this Nov 29, 2019
addaleax added a commit that referenced this pull request Nov 29, 2019
@addaleax
src: use uv_async_t for WeakRefs
fad952a 
Schedule a task on the main event loop, similar to what the HTML
spec recommends for browsers.

Alternative to #30198

PR-URL: #30616
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@addaleax addaleax deleted the finalization-tasks branch November 29, 2019 01:17
addaleax added a commit that referenced this pull request Nov 29, 2019
@addaleax
src: use uv_async_t for WeakRefs
9e9e48b 
Schedule a task on the main event loop, similar to what the HTML
spec recommends for browsers.

Alternative to #30198

PR-URL: #30616
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@addaleax @targos
src: use uv_async_t for WeakRefs
ef9dd60 
Schedule a task on the main event loop, similar to what the HTML
spec recommends for browsers.

Alternative to #30198

PR-URL: #30616
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@addaleax @BethGriggs
src: use uv_async_t for WeakRefs
50b7f84 
Schedule a task on the main event loop, similar to what the HTML
spec recommends for browsers.

Alternative to #30198

PR-URL: #30616
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

+1 more reviewer

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@addaleax @nodejs-github-bot @bnoordhuis @devsnek