Closed
Conversation
nodejs-github-bot
added
c++
devsnek
force-pushed
the
refactor-weak-refs
branch
from
7aa2a72 to
1aff25f
Compare
addaleax
reviewed
Oct 31, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Can you explain the motivation here? I feel like this is a step in an odd direction, and I'd still prefer to run these as tasks on an uv_async_t rather than doing so using the miceotask queue or running at the end of the callback scope...
|
|
||
| void HostCleanupFinalizationGroupMicrotask(void* data) { | ||
| FinalizationGroupCleanupTask* t = | ||
| reinterpret_cast<FinalizationGroupCleanupTask*>(data); |
| env->RegisterFinalizationGroupForCleanup(group); | ||
| env->isolate()->EnqueueMicrotask( | ||
| HostCleanupFinalizationGroupMicrotask, | ||
| new FinalizationGroupCleanupTask(env, group)); |
Member
There was a problem hiding this comment.
I think this misses a corresponding delete?
Member
Author
|
@addaleax ClearKeptObjects is in the correct place either way. Why would a uv_async_t be preferable for the finalization cleanup? |
Member
|
@devsnek I still think it’s preferable to run these callbacks after GC without an unbounded delay, like whatwg/html#4571 suggests it for HTML. |
Member
|
Hm … ping @devsnek? I’m currently running into the “Cannot create a handle without a HandleScope” crash :) |
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Nov 23, 2019
Schedule a task on the main event loop, similar to what the HTML spec recommends for browsers. Alternative to nodejs#30198
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes