Skip to content

src: change env.h includes for forward declarations when possible#30133

Closed
alferpal wants to merge 1 commit intonodejs:masterfrom
alferpal:cleanup/reduce_number_of_includes_env_and_env-inl
Closed

src: change env.h includes for forward declarations when possible#30133
alferpal wants to merge 1 commit intonodejs:masterfrom
alferpal:cleanup/reduce_number_of_includes_env_and_env-inl

Conversation

@alferpal
Copy link
Contributor

@alferpal alferpal commented Oct 26, 2019

Due to how the Environment class is used through the codebase,
there are a lot of includes referencing either env.h or env-inl.h.

This can cause that when any development touches those libraries,
a lot of files have to be recompiled.

This commit attempts to change those includes by forward declarations
when possible to mitigate the issue.

Partial fix for #27531

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

First PR in node, so if anything can be done better, please, tell me.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 26, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 26, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26210/

joyeecheung
joyeecheung approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alferpal
Copy link
Contributor Author

alferpal commented Oct 28, 2019

I want to take a look at the CI failures sometime this week, but I have it already packed, so might not have time to do this until Friday

@alferpal
src: change env.h includes for forward declarations
7c38760 
Due to how the Environment class is used through the codebase,
there are a lot of includes referencing either env.h or env-inl.h.
This can cause that when any development touches those libraries,
a lot of files have to be recompiled.
This commit attempts to change those includes by forward declarations
when possible to mitigate the issue.

Refs: #27531
@addaleax addaleax mentioned this pull request Oct 29, 2019
Closed
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. and removed c++ Issues and PRs that require attention from people who are familiar with C++. labels Oct 29, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 29, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26240/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 29, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26241/

@addaleax
Copy link
Member

addaleax commented Oct 31, 2019

Landed in 99c1238, thanks for the PR, and so nice to see you here! ✨

@addaleax addaleax closed this Oct 31, 2019
addaleax pushed a commit that referenced this pull request Oct 31, 2019
@alferpal @addaleax
src: change env.h includes for forward declarations
99c1238 
Due to how the Environment class is used through the codebase,
there are a lot of includes referencing either env.h or env-inl.h.
This can cause that when any development touches those libraries,
a lot of files have to be recompiled.
This commit attempts to change those includes by forward declarations
when possible to mitigate the issue.

Refs: #27531

PR-URL: #30133
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@gireeshpunathil gireeshpunathil mentioned this pull request Nov 1, 2019
Closed
4 tasks
targos pushed a commit that referenced this pull request Nov 5, 2019
@alferpal @targos
src: change env.h includes for forward declarations
ec7b69f 
Due to how the Environment class is used through the codebase,
there are a lot of includes referencing either env.h or env-inl.h.
This can cause that when any development touches those libraries,
a lot of files have to be recompiled.
This commit attempts to change those includes by forward declarations
when possible to mitigate the issue.

Refs: #27531

PR-URL: #30133
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@alferpal @targos
src: change env.h includes for forward declarations
d0fadb0 
Due to how the Environment class is used through the codebase,
there are a lot of includes referencing either env.h or env-inl.h.
This can cause that when any development touches those libraries,
a lot of files have to be recompiled.
This commit attempts to change those includes by forward declarations
when possible to mitigate the issue.

Refs: #27531

PR-URL: #30133
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@alferpal @targos
src: change env.h includes for forward declarations
902f5d9 
Due to how the Environment class is used through the codebase,
there are a lot of includes referencing either env.h or env-inl.h.
This can cause that when any development touches those libraries,
a lot of files have to be recompiled.
This commit attempts to change those includes by forward declarations
when possible to mitigate the issue.

Refs: #27531

PR-URL: #30133
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@alferpal @targos
src: change env.h includes for forward declarations
af7d5f5 
Due to how the Environment class is used through the codebase,
there are a lot of includes referencing either env.h or env-inl.h.
This can cause that when any development touches those libraries,
a lot of files have to be recompiled.
This commit attempts to change those includes by forward declarations
when possible to mitigate the issue.

Refs: #27531

PR-URL: #30133
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@alferpal @targos
src: change env.h includes for forward declarations
c52b292 
Due to how the Environment class is used through the codebase,
there are a lot of includes referencing either env.h or env-inl.h.
This can cause that when any development touches those libraries,
a lot of files have to be recompiled.
This commit attempts to change those includes by forward declarations
when possible to mitigate the issue.

Refs: #27531

PR-URL: #30133
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

+1 more reviewer

@devnexen devnexen devnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alferpal @nodejs-github-bot @addaleax @fhinkel @cjihrig @joyeecheung @devnexen