src: reduced env.h and env-inl.h include lines and added forward declarations of class Environment where necessary.

[sarkararpan710]

Reduces env.h and env-inl.h include lines and added forward declarations of class Environment.
Some files had references to Environment* types in the code but for those files, no include<env.h> or include<env-inl.h> files where present. In those cases I added a forward declaration of class Environment.

Running the vcbuild test on windows ran it successfully.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[addaleax]

@BridgeAR @sarkararpan710 I don’t think there’s much to review here until the PR compiles & passes linting + tests … for one, the forward declaration of Environment needs to happen inside a namespace node { ... }, but removing the inline header include still won’t work (= won’t compile) in all cases.

[sarkararpan710]

Yeah I saw that it didn't compile and I am actually looking and exploring methods to potentially speed up the build times using the forward declaration. I guess even first time contributions on open source projects are tough 😂. Nonetheless I would like to know further on how I could help resolve the issue.

[fhinkel]

Should this remain open?

[gireeshpunathil]

looks like this might have been made redundant through #30133 . Looking at the number of files touched, it is possible that this is still relevant. A rebase followed by a successful compilation can tell us. @sarkararpan710 - are you willing to pursue this further? I can provide some assistance to make progress.

[addaleax]

So … I tried rebasing this PR, but it seems like this only adds forward declarations outside of the node namespace (where they can’t be used) and still wouldn’t compile/pass linting because it removes includes that are actually used.

I think closing this makes sense.